vscode-symbols icon indicating copy to clipboard operation
vscode-symbols copied to clipboard

Feat: Generative variants

Open barelyhuman opened this issue 1 year ago • 2 comments

  • [x] Removes the extension since the complexity isn't needed anymore
  • [x] Add and remove needed details from the package.json
  • [x] script to generate the variants with differences in props and file paths

Need confirmation on the following

  • Do we wish to keep the extension in place ?
  • Do we need the CI / Github action to build during a publish a step
  • Do we need the PR actions to just test if the generation works or do we need the generated files in the PR to actually be usable in a plugin?

Fix: #46

barelyhuman avatar Aug 30 '22 18:08 barelyhuman

Do we wish to keep the extension in place ?

Not sure what you mean by this?

Do we need the CI / Github action to build during a publish a step

I was thinking we could have this as a publish step that happens locally, what are your thoughts?

Do we need the PR actions to just test if the generation works or do we need the generated files in the PR to actually be usable in a plugin?

We could have a test in a PR action to ensure nothing breaks

Also: I need to test this to see if this new extension will work on the web/remote so let me know when you think this is ready and I can start testing it. Some docs on web extensions.

miguelsolorio avatar Aug 30 '22 19:08 miguelsolorio

Do we wish to keep the extension in place ?

Not sure what you mean by this?

If you see the commits, the first one get's rid of all the JS logic , do we want to keep the logic? if yes, I'll revert that commit (doesn't make the release a breaking one) if not, then we just move ahead (makes the release a breaking one)

I was thinking we could have this as a publish step that happens locally, what are your thoughts?

Either would be fine, it's just a single JS file that needs to be executed

We could have a test in a PR action to ensure nothing breaks

Understood.

Also: I need to test this to see if this new extension will work on the web/remote so let me know when you think this is ready and I can start testing it. Some docs on web extensions

Shouldn't need to modify anything, you can go ahead and test it, just run this in the shell

./scripts/generate.js

and add the variants folder to the publish for now

barelyhuman avatar Aug 30 '22 19:08 barelyhuman