miguel

Results 84 comments of miguel

Ready for review

I think the new watcher and order of operations is good and makes sense. My feedback is mostly on additional error handling and some simplifications. The functions that deal with...

This old [PR](https://github.com/hop-protocol/hop/pull/413) could use a review to handle this https://github.com/hop-protocol/hop/pull/413.

I think we want to keep npm as the package installer for all the packages for simplicity. I believe only the frontend package uses yarn because removing the yarn lock...

A few observations expected: Select bridge with better rate after inputting amount actual: Native bridge was not chosen when it had a better rate (maybe a debounce here is needed?)...

@kangarang let me know if you have any questions on the comments

@kangarang that makes sense. the problem is that it's not clear that it'll continue using the option that was previously selected. I think there needs to be an optional setting...

Code updates look good 👍 can we deploy to a staging site (mainnet2) for live testing?

minor bug expected: when wallet is not connected, send button should prompt to connect wallet or be disabled with message to connect wallet actual: send button is active but nothing...

bug expected: ability to approve or send tokens, or show message why buttons are disabled actual: all action buttons are disabled approve and send buttons also appear to be different...