go-github-mock

go-github-mock copied to clipboard

The `github.ErrorResponse.Error()` method panics

3

The `ErrorResponse.Error()` implementation [references the `*http.Response`](https://github.com/google/go-github/blob/b338ce623f50aeaf4cbf7f4195a79d0d302f9a65/github/github.go#L707) which is not provided by `go-github-mock`. The examples use type assertions to work around this, but wrapping errors is a common pattern in Go...

sebnow

Enable GH Actions

2

migueleliasweb

Suggestions and findings

5

This is very useful and saved me quite some time, when I otherwise would have had to do this "by hand" when integrating Github tests into our `testify` based unit...

Marakai

- when `CurrentIndex` == `len(Responses)` it means that if you will try to get responses[CurrentIndex] will make out of index panic. we are expecting to panic [from here](https://github.com/ElisarEisenbach/go-github-mock/blob/bb3d3b6b1968538665a5143c9124dc0bb8768394/src/mock/server.go#L41-L44) - fix...

ElisarEisenbach

This PR is stacked on top of migueleliasweb/go-github-mock#59.

jlucktay