MonoTouch.Dialog icon indicating copy to clipboard operation
MonoTouch.Dialog copied to clipboard

Published 20 hours ago • verified publisher icon migueldeicaza

Untitled

Open csteeg opened this issue 13 years ago • 4 comments

csteeg avatar Apr 06 '11 09:04 csteeg

Could you produce a diff between my branch and yours? It seems like this would at least let me see some of the changes. Currently the changes as made available on this pull request are hard to see since they consist mostly of newline changes

migueldeicaza avatar Apr 06 '11 20:04 migueldeicaza

Yes, sorry for that. My last checkin fixes the newlines. The entire/fixed diff can be viewed here: https://github.com/migueldeicaza/MonoTouch.Dialog/pull/45/files

csteeg avatar Apr 06 '11 21:04 csteeg

I got a few of the other patches, but I do not understand the radio changes.

Can you explain what the problem is, and what this patch changes to fix it?

migueldeicaza avatar Apr 10 '11 21:04 migueldeicaza

The RadioSelectionAttribute has a target property, but that property is never used in the current code base. The current code base, just skips any Int-typed property. (So it is impossible to add a normal int field like Age) Then, if such an int-typed property has a RadioSelectionAttribute, it requires the next property(!) to be an IEnumerable, no matter if the target property equals that member's name.

The change in my code is that whenever an IEnumerable is encountered, it looks for an int-member that has a RadioSelectionAttribute where Target is equal to the IEnumerable's name. Also, int typed members that don't have the RadioSelectionAttribute, ar added as entry elements to allow someone to input a number.

csteeg avatar Apr 11 '11 08:04 csteeg