eslint-config-love icon indicating copy to clipboard operation
eslint-config-love copied to clipboard

fix: subject fixed failure to propgate extension rules present in standard

Open 6XGate opened this issue 3 years ago • 6 comments

What is the purpose of this pull request? (put an "X" next to item)

[ ] Documentation update [x] Bug fix [ ] New feature [ ] Other, please explain:

What changes did you make? (Give an overview)

Ensured that all @typescript-eslint rules are propagated if they appear in the Standard JS configuration.

Which issue (if any) does this pull request address?

#582 Some upstream standard rules are not properly propagated to their @typescript-eslint version

Is there anything you'd like reviewers to focus on?

6XGate avatar May 28 '21 02:05 6XGate

🙌 Thanks for opening this pull request! You're awesome.

welcome[bot] avatar May 28 '21 02:05 welcome[bot]

@6XGate sorry for not reviewing your PR until now, if we review it, will you proceed with it?

rostislav-simonik avatar Jun 20 '22 06:06 rostislav-simonik

proceed with it? I'm not sure what you mean by that. It likely will need to corrections due to recently landed PRs. It was meant to better keep in sync with standard by sync all know (at the time) shared/replaced plain ESLint rules with their TypeScript counter part

6XGate avatar Jul 15 '22 18:07 6XGate

@6XGate yes. If we review it will you follow through with it with it? It's been a while. That's why we ask.

mightyiam avatar Jul 15 '22 23:07 mightyiam

Sure, I'll give a try at it again soon.

6XGate avatar Jul 21 '22 03:07 6XGate

I'm happy to hear that, @6XGate . But we haven't reviewed it yet, so don't spend time yet. Now that I know you're willing to go through with it, we'll review it for you. Not before August though.

mightyiam avatar Jul 22 '22 10:07 mightyiam