instauto icon indicating copy to clipboard operation
instauto copied to clipboard

docker support with env variables support

Open maxxxdj opened this issue 2 years ago • 7 comments

maxxxdj avatar Mar 29 '22 18:03 maxxxdj

Hey, I've ammended the readme change + the null check for the numeric variables. I also added an option if we pass only one user in the USERS_TO_FOLLOW section.

About the other changes -> i removed them, but i didn't succeed to squash the commits, hope you can do that. The other changes are important, related to puppeteer to be ran properly in a container.

Cheers!

maxxxdj avatar Mar 31 '22 19:03 maxxxdj

thanks. I did some additional improvements. I still see that yarn.lock, package.json, index.js changes are part of this PR. I don't think they are needed? If not, could you revert those?

mifi avatar Apr 01 '22 04:04 mifi

thanks. I did some additional improvements. I still see that yarn.lock, package.json, index.js changes are part of this PR. I don't think they are needed? If not, could you revert those?

I've tried with the old ones, but Dockerfile was failing to build. image I suggest to try to run it locally and if it's not a problem to leave them. Cheers!

maxxxdj avatar Apr 01 '22 18:04 maxxxdj

That’s odd. Maybe try yarn add instuto instead of npm install instauto

mifi avatar Apr 02 '22 11:04 mifi

That’s odd. Maybe try yarn add instuto instead of npm install instauto

It worked! Great, thanks. The only changes now are some IDE or whitespaces. I've changed the docker container name to be the correct as your project and product - "instauto".

Cheers

maxxxdj avatar Apr 03 '22 10:04 maxxxdj

thanks! i would appreciate if you also remove the whitespace changes. after that is solved i think this can be merged

mifi avatar Apr 03 '22 10:04 mifi

thanks! i would appreciate if you also remove the whitespace changes. after that is solved i think this can be merged

done!

maxxxdj avatar Apr 03 '22 11:04 maxxxdj

Any news on this PR? Would love to use a simple docker compose to deploy instauto.

Tried building an image with the dockerfile (first time) - but failed.

thegreenmilecornant avatar Feb 26 '23 12:02 thegreenmilecornant

Any news on this PR? Would love to use a simple docker compose to deploy instauto.

Tried building an image with the dockerfile (first time) - but failed.

Hey! I'm not sure why the owner didn't merged this one. It was running fine on my side and even I had it with env variables so I can run different accounts. If you copied that file and trying it on the current master maybe won't work, due to changes in master branch.

Try to ping mifi

maxxxdj avatar Feb 26 '23 19:02 maxxxdj

Hi. I left some code review questions that were not answered

mifi avatar Feb 27 '23 02:02 mifi

Hey! I'm not sure why the owner didn't merged this one. It was running fine on my side and even I had it with env variables so I can run different accounts. If you copied that file and trying it on the current master maybe won't work, due to changes in master branch.

Try to ping mifi

OK. Would you be so kind and look at the requested changes by @mifi and update the PR 😃 ? Would love to deploy this in Docker!

thegreenmilecornant avatar Feb 27 '23 07:02 thegreenmilecornant

Hi. I left some code review questions that were not answered

So I hope you are asking about the CMD...

First of all I am not a node.js programmer, but from what I got from logs I saw that it needs an upgrade on the yarn dependency and pupeteer. This is why I added those arguments when executing the run command.

About COPY command - I am copying the root folder to docker image folder, from where I will execute the program.

maxxxdj avatar Feb 27 '23 20:02 maxxxdj

if these changes look ok then we can merge

mifi avatar Mar 04 '23 09:03 mifi

I haven't tested this but let me know if it doesnt work and we can do another PR to fix it

mifi avatar Mar 04 '23 12:03 mifi