Mikael Finstad

Results 1495 comments of Mikael Finstad

I mean breaking as in api breaking: if util.inspect changes the api and someone is consuming the event on redis, then it could break their implementation

You mean stop sending the whole Error object and instead just send `message`? Yesterday I agreed yes, but now I realised that I misread the code and I thought it...

Managed to reproduce, working on a fix

the problem seems to appear when the s3 bucket does not have the correct CORS policy configured as [described in the docs](https://uppy.io/docs/aws-s3/#setting-up-your-s3-bucket) - in particular `"ExposeHeaders": ["ETag", "Location"]`. in previous...

For Dropbox, someone suggested this: > Have you considered the batch endpoint for this? > Seems it can support up to 25 at a time: > https://www.dropbox.com/developers/documentation/http/documentation#files-get_thumbnail_batch

i'm open to switching to some module to do list virtualization, like for example https://tanstack.com/virtual/latest - however if we'ere going to instead keep our own implementation I think we should...

I assume you checked that using `currentTarget` in place of `target` is safe (e.g. they seem to differ with regards to bubbling)

> I get add the hooks as our setup breaks what do you mean by that? We had so many problems with broken uppy in react in the past and...

I just tested and it seems to be working! Will create a PR