react-native-markdown-renderer icon indicating copy to clipboard operation
react-native-markdown-renderer copied to clipboard

Typescript typings packages listed as runtime dependencies

Open cubabit opened this issue 7 years ago • 1 comments
trafficstars

Is it correct that the typescript typings modules are listed as non-dev dependencies?

https://github.com/mientjan/react-native-markdown-renderer/blob/master/package.json#L27

I am using a lower version of @types/react-native in my project and the dependency in react-native-markdown-renderer's is causing my react native packager to fail with the following:

Failed to build DependencyGraph: @providesModule naming collision: Duplicate module name: @types/react-native

cubabit avatar May 31 '18 14:05 cubabit

Thats because they are used in the d.ts file https://github.com/mientjan/react-native-markdown-renderer/blob/master/src/index.d.ts#L2 maybe move them to a peer Dependency???

mientjan avatar Jun 04 '18 10:06 mientjan