inspectrum icon indicating copy to clipboard operation
inspectrum copied to clipboard

Color SigMF Annotations (v2)

Open jacobagilbert opened this issue 2 years ago • 1 comments

This is an update to #195 that provides essentially the same features through the much more sane presentation.sigmf-ext.md which can be found in this proposal to upstream it.

Example thus becomes:

  ...
  "annotations": [
    {
      "core:sample_start": 3383600,
      "core:sample_count": 197312,
      "core:freq_upper_edge": 201379186,
      "core:freq_lower_edge": 200727361,
      "core:description": "UNKNOWN",
      "presentation:color": "#55ffffff"
    },
    {
      "core:sample_start": 7327744,
      "core:sample_count": 397312,
      "core:freq_upper_edge": 198540829,
      "core:freq_lower_edge": 197964200,
      "core:description": "VALID",
      "presentation:color": "#90ee90"
    },
    {
      "core:sample_start": 5327744,
      "core:sample_count": 897312,
      "core:freq_upper_edge": 195540829,
      "core:freq_lower_edge": 194964200,
      "core:description": "ERROR",
      "presentation:color": "#db7093"
    },
    ...
  ]

The use of named colors is not technically supported by the extension, however any valid QColor string will work here.

jacobagilbert avatar Mar 28 '22 17:03 jacobagilbert

Nice :)

Two thoughts:

  • Let's merge the upstream change first ;)
  • I guess at some point we need to think about if there should be some kind of SigMF options tab in the main window.

Edit: And maybe we should even not parse named colors? It might prevent people from producing invalid meta data and thinking it's OK...

schneider42 avatar Mar 30 '22 13:03 schneider42