codi.link icon indicating copy to clipboard operation
codi.link copied to clipboard

Published 20 hours ago • verified publisher icon midudev

New layouts and multiple resizer added

Open stylessh opened this issue 4 years ago • 12 comments

  • [x] Layout settings to change the editor view.
  • [x] Layout settings are stored on local storage, among the other ones.
  • [x] Multiple resizer added.

Keep using split grid.

CLOSED #5 CLOSED #16 CLOSED #34 CLOSED #139

stylessh avatar Oct 02 '21 21:10 stylessh

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/midudev-pro/codi-link/5hHZvPctNqbm25yGYSsHzbsaueUW
✅ Preview: https://codi-link-git-fork-stylessh-main-midudev-pro.vercel.app

vercel[bot] avatar Oct 02 '21 21:10 vercel[bot]

@stylessh nice work! I've been testing and there are a few bugs... this is one of them image

rxb3rth avatar Oct 03 '21 16:10 rxb3rth

@stylessh nice work! I've been testing and there are a few bugs... this is one of them image

Could you tell me how this bug happened?

stylessh avatar Oct 03 '21 16:10 stylessh

@stylessh nice work! I've been testing and there are a few bugs... this is one of them image

Could you tell me how this bug happened?

Occurs when you move the gutter and change to another layout.

rxb3rth avatar Oct 03 '21 16:10 rxb3rth

I'll see what's going on, thanks!

stylessh avatar Oct 03 '21 20:10 stylessh

Bug solved. Are there more of them?

stylessh avatar Oct 03 '21 20:10 stylessh

Bug solved. Are the more of them?

Todo bien!

rxb3rth avatar Oct 04 '21 13:10 rxb3rth

@stylessh this was awesome. Sadly @dartilesm implemented something similar. Do you think you could add the layouts you proposed but with the already merged code? I love the layouts you proposed! I could create an issue with it and assign to you so nobody works on that. What do you think?

midudev avatar Oct 08 '21 09:10 midudev

I'll do it!

stylessh avatar Oct 08 '21 13:10 stylessh

@midudev new layouts are available, no conflicts.

stylessh avatar Oct 11 '21 15:10 stylessh

I would love to merge this PR but there's much styling code changes that are not needed and would start provoking a lot of conflicts with next PRs. Could you avoid the styling changes and stick to the needed new code so we could merge this seamlessly? 🙇‍♂️

midudev avatar Oct 13 '21 21:10 midudev

I would love to merge this PR but there's much styling code changes that are not needed and would start provoking a lot of conflicts with next PRs. Could you avoid the styling changes and stick to the needed new code so we could merge this seamlessly? 🙇‍♂️

I just added the CSS code needed for the three new layouts, could you be more specific and tell me what changes are not needed? Thanks a lot! ~

stylessh avatar Oct 15 '21 22:10 stylessh