codi.link icon indicating copy to clipboard operation
codi.link copied to clipboard

Published 20 hours ago • verified publisher icon midudev

feat(Root): Add theme support

Open QuevedoIB opened this issue 3 years ago • 9 comments

User can now select from a wider list of theming options

image

User can now use any vscode theme in codi.link by generating theme file

image

Copying and pasting the content into the textarea for custom theme and selecting the Custom option from select

image

CLOSES #2 #31

QuevedoIB avatar Oct 02 '21 14:10 QuevedoIB

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/midudev-pro/codi-link/FZL8z3VFMzSaz6iprbx4Jz5DReBh
✅ Preview: https://codi-link-git-fork-quevedoib-feature-extend-64782d-midudev-pro.vercel.app

vercel[bot] avatar Oct 02 '21 14:10 vercel[bot]

Hi @QuevedoIB, the json files only contains syntax for JavaScript and not apply correctly colors in rest of editors.

In codi.link image

In vscode image

david-ponc avatar Oct 02 '21 19:10 david-ponc

Also, just checked this PR also fixes #31

jsdocs red jsdocs2

QuevedoIB avatar Oct 04 '21 17:10 QuevedoIB

Deployment failed with the following error:

Invalid request: `target` should be string.

vercel[bot] avatar Oct 06 '21 22:10 vercel[bot]

Hi @QuevedoIB theme view awesome 🔥 but now not working autocomplete 😅 It also happens to you or only to me? 😅

david-ponc avatar Oct 07 '21 02:10 david-ponc

Hi @QuevedoIB theme view awesome 🔥 but now not working autocomplete 😅 It also happens to you or only to me? 😅

Hmm could you check it again? If you mean suggestions they are working for me, if you mean typing <div> and getting the </div> closing tag there's a PR pending to be merged for that.

QuevedoIB avatar Oct 07 '21 10:10 QuevedoIB

@midudev I've removed some things to make PR easier to review and fixed the conflicts, could you check if its okay to merge it? Minimap already gets styled and everything seems to work fine for me.

QuevedoIB avatar Oct 17 '21 18:10 QuevedoIB

07/11/2021

  • No conflicts with main
  • Fixed feedback from midu (bracket pairs not adding new line when pressing enter between them)

QuevedoIB avatar Nov 06 '21 23:11 QuevedoIB

@midudev Continuous integration is failind but it's not related to the PR.

Error: The process '/opt/hostedtoolcache/node/14.18.1/x64/bin/npm' failed with exit code 1 https://stackoverflow.com/questions/69118749/github-action-error-while-running-unit-test-pipeline

I believe it's a bug in the node version used to run the tests.

Could you check it out?

QuevedoIB avatar Nov 27 '21 14:11 QuevedoIB