nbt2json icon indicating copy to clipboard operation
nbt2json copied to clipboard

Published 20 hours ago • verified publisher icon midnightfreddie

Support new tag: Tag_Long_Array

Open VADemon opened this issue 5 years ago • 4 comments

Added in Java 1.12: https://minecraft.gamepedia.com/NBT_format Id = 12, I don't see it implemented

VADemon avatar Jul 27 '19 19:07 VADemon

Good find, thanks. Been very busy at work the past few weeks but should have some time to look at this. Shouldn't be hard to add.

midnightfreddie avatar Aug 10 '19 17:08 midnightfreddie

Give the latest release v0.3.0 a try. It should fix the NaN handling, and I implemented the long/int64 array for tag ID 12, although I didn't have a sample to test it on.

midnightfreddie avatar Aug 11 '19 06:08 midnightfreddie

Me neither :) Remind me in a couple of weeks.

NAN sample uploaded here: https://github.com/VADemon/nbd/blob/sample-nan/test/Player-nan-value.dat

EDIT, 2020: NAN works, I couldn't find a TAG_LONG_ARRAY example from Minecraft. And NBTExplorer doesn't appear to write correct ones? Hm.

VADemon avatar Aug 11 '19 09:08 VADemon

May 2020 update: I think this feature was added back in August in v0.3.0, but there doesn't seem to be any long array values in use in Minecraft to test against.

I'll leave the issue open until we can verify it or until I get tired of looking at it and decide if we can't test for failure then it must be good.

Edit: For the forthcoming v0.4.0, long lists have been converted (along with longs) to high-32/low-32 pairs of numbers, and tests are in place to validate conversion and round-trip conversions. But still no real world data to test against.

midnightfreddie avatar May 01 '20 18:05 midnightfreddie