Sick-Beard icon indicating copy to clipboard operation
Sick-Beard copied to clipboard

Published 20 hours ago • verified publisher icon midgetspy

Pathing issueIssue 2571, 2585, 2591

Open Mad-Piggy opened this issue 10 years ago • 13 comments

Patch for issues:

  • Issue 2571: Plex (and possibly pushbullet) notifications no longer work
  • Issue 2585: Patch for: TypeError: coercing to Unicode: need string or buffer, instance found
  • Issue 2591: coercing to Unicode: need string or buffer, instance found

Mad-Piggy avatar May 06 '15 22:05 Mad-Piggy

Thanks for the fix! I'm happy to have my Plex notifications working again.

dimfeld avatar Jun 05 '15 19:06 dimfeld

Thanks from me as well. Plex updates don't error anymore for me

jakswa avatar Jun 08 '15 01:06 jakswa

Is this on the Dev or master branch yet?

CyberMew avatar Jun 08 '15 02:06 CyberMew

I don't think so. I just manually patched it in to my local copy from the PR.

dimfeld avatar Jun 08 '15 02:06 dimfeld

Is there a timeline on when this will be merged in?

KevinAnthony avatar Jun 10 '15 15:06 KevinAnthony

It is indeed not yet implemented in dev or master. But this is something we have to w8 for midgetspy to do. If you realy want to pull this patch, you can from my repository: https://github.com/Mad-Piggy/Sick-Beard

Mad-Piggy avatar Jun 10 '15 16:06 Mad-Piggy

Just wanted to mention that the fix for the coercion errors is also provided in #939. That problem is actually bigger than the Plex notifier but shouldn't have any impact on the functionality. It's the logging of an error that goes wrong.

I think the problem with Plex was that the password manager wasn't supplied with the getURL() call, so it failed. But due to the unrelated problem with the logging of that error, it wasn't clear what exactly was going wrong. So perhaps it would be easier to have this merged if both PR's focus on fixing only 1 thing, with #939 for the logging fix and this PR for the Plex fix. I think including too many things in 1 PR might make it harder to determine if it can (and should) be merged (but I could be wrong about that).

Note that with only the plex fix your branch would no longer cause an error when connecting to plex and the error would no longer need to be logged so the coercion problem wouldn't occur anymore either. Just to say that it would still remain entirely functional.

arucard21 avatar Jun 17 '15 08:06 arucard21

Just wanted to say thanks for the fixes! Saved them in a stable branch and am never updating SB again.

jordansaints avatar Jul 04 '15 22:07 jordansaints

Any eta on when this pull request will be merged into development or master?

jpanski avatar Oct 10 '15 17:10 jpanski

I think development on SickBeard has ceased... Personally I've switched to SickRage which is somewhat based on this one but still under active development.

dimfeld avatar Oct 10 '15 17:10 dimfeld

Wow, that's really sad if true. I hope that's not the case and he's just on a sabbatical.

jpanski avatar Oct 10 '15 17:10 jpanski

Yeah, hard to tell. He hasn't said anything on the forums at sickbeard.com either, so nobody really knows for sure...

dimfeld avatar Oct 10 '15 21:10 dimfeld

By the way, if folks want to apply these patches (and/or any others while the primary developer is missing), there are good instructions here: http://stackoverflow.com/a/28729484. Basically, you can create pull requests between the requests here and your own forked repository.

Amadeus- avatar Oct 30 '15 11:10 Amadeus-