Sick-Beard icon indicating copy to clipboard operation
Sick-Beard copied to clipboard

Update the scene exception db before checking for updates

Open jtatum opened this issue 12 years ago • 3 comments

This addresses an issue that can occur when using a zipball/tarball of a tagged version. The version checker encounters an exception which ends the thread before the scene exceptions are populated. Swapping the order so the more stable exception retrieval runs first fixes the issue.

jtatum avatar May 23 '12 07:05 jtatum

What exceptions are thrown, can you post a log? A better fix would be to catch those exceptions and log them and then carry on.

midgetspy avatar Jun 05 '12 03:06 midgetspy

@jtatum any update on this?

thezoggy avatar Jun 29 '13 10:06 thezoggy

So, basically, I was using homebrew to install SB on OS X. Homebrew gets a specific revision of the source from GH, but doesn't do it as a clone, it just copies it in (having its own update mechanism).

This is probably an unsupported way to do things, but in terms of actual functionality, the only thing it broke was the scene exception DB since the update mechanism fails before the scene exceptions get updated. In any case, I just switched to installing it from Git like normal, so...

I can definitely update the pull to record the exception, though, if desired.

jtatum avatar Jun 29 '13 15:06 jtatum