Sick-Beard icon indicating copy to clipboard operation
Sick-Beard copied to clipboard

Soundtrack Language Support + Newzbin provider fixes

Open Toilal opened this issue 12 years ago • 7 comments

Added: Soundtrack Language support in application. New Soundtrack Language parameter in TVShow.

Added: Soundtrack Language support in Newzbin provider. Other providers are not implemented yet.

Added: Custom Search Names parameter to TVShow objects. Very useful to force a custom scene release name (TVDB translates show names, scene does not).

Added: Exception logging method (exceptions module).

Fixed: Newzbin provider in Download/Blackhole mode, SSL Read error (urllib > urllib2)

Git: Some ignore added (for PyDev/Eclipse)

Sorry for the big commit, that was 1st time i use GIT, next time i will make more commits (1 commit / function)

Toilal avatar Nov 12 '11 01:11 Toilal

nice pull request, when is it comming?

tobiaszuercher avatar Dec 07 '11 16:12 tobiaszuercher

seems like there is a bunch of things grouped into one pull request. i'd recommend breaking each feature out to its own if you really want this to be pulled. also not sure what soundtrack language support is..

thezoggy avatar Dec 14 '11 06:12 thezoggy

soundtrack language support is the ability to choose the language for the movie. its possible to download tv shows in other language than english (if the provider supports it).

at least the newzbin patch should be pulled because newzbin still doesn't work (SSL read error)

tobiaszuercher avatar Jan 09 '12 20:01 tobiaszuercher

also, you shouldn't work in your 'master' branch as it will just get cluttered with midget's commits if you pull/update it. also, i'd recommend breaking each feature out to its own if you really want this to be pulled. as each thing needs to be tested before it would make it into master.

thezoggy avatar Jan 10 '12 00:01 thezoggy

Hello toilal, im very sad to see That your fork of sickbeard disapeared. I was using it With some customization i did for à long. But unfortunately i made some cleanup and lost everything. So i was able to modify your source to make it work like i wanted With newzbin nzbmatrix and nzb.su. But those modifications was made on your développement such as foreign langage and custom scene naming and That was magically working. But im only à new coing Guy, and i am able to adapt or modify existing code but im totally unable to code what toi did. So are you able,please, to reup your source With soundtrack and custom scène naming. Im french and it was very use full for me. Thank you please

an0Nym0us63 avatar Aug 06 '12 00:08 an0Nym0us63

Sorry, i don't have the sources anymore :(

But you can still see changes in this pull request ... and merge them.

Toilal avatar Aug 06 '12 00:08 Toilal

Thanks i did it and its working pretty well

an0Nym0us63 avatar Aug 23 '12 16:08 an0Nym0us63