GreynirServer icon indicating copy to clipboard operation
GreynirServer copied to clipboard

Spring Cleaning

Open sveinbjornt opened this issue 3 years ago • 2 comments

  • Got rid of /correct.api endpoint and all code it required
  • Deleted lots of unused .conf files and utilities in tools/
  • Refactoring and cleanup

sveinbjornt avatar Oct 12 '22 18:10 sveinbjornt

@vthorsteinsson @Holado

The Greynir repo still contains all sorts of stuff (data in resources/ and config/, code in tools/) for evaluating and extending our BÍN vocabulary. It seems to me that this belongs in the BinPackage repo rather than Greynir now that the two have been properly decoupled. Also, some of the helper tools probably belong in GreynirPackage.

What should be thrown away or moved to a different repo? It would be great to get feedback from you guys about this. Candidates for moving or deletion:

config/Adjectives.conf
config/FamilyNames.conf
config/Vocab.conf

resources/formers.txt
resources/last.txt
resources/obeygd.hreinsad.txt

tools/compmaker.py
tools/dawgbuilder.py
tools/external_data_validator.py
tools/mim.py
tools/obeygd.py
tools/ptest.py
tools/sortfile.py
tools/speedtest.py
tools/verbs.py
tools/vocab.py

sveinbjornt avatar Oct 13 '22 18:10 sveinbjornt

At least resources/formers.txt, resources/last.txt, resources/obeygd.hreinsad.txt can be deleted from this repo, they are now in the BinPackage repo.

Same applies to tools/dawgbuilder.py.

Not sure about the others - would need to look at them individually.

vthorsteinsson avatar Oct 14 '22 12:10 vthorsteinsson

@vthorsteinsson Vil fá grænt ljós á þetta.

sveinbjornt avatar Oct 22 '22 23:10 sveinbjornt