middlewarehq
Issue # 559 Fixed. CLI now closes when pressing X to exit the dev CLI
Linked Issue
Closes issue # 559 https://github.com/middlewarehq/middleware/issues/559
Proposed change
The changes made allow the CLI to close when pressing X in order to exit the dev CLI.
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.
Thanks for your contribution, @carmen-cruzarana! :)
There's just one tiny thing left. We'd still need you to sign the CLA.
Additionally, it's a great idea to get confirmation on an issue that you'd like to work on it, and that it's not worked upon by someone else in the community, or by our maintainers to avoid accidental wastage of time or rework. :)
Fortunately in this case no one else was working for it, but it's a good one to keep in mind in the future.
It also appears that the linter is failing, so you might want to look into that as well.
Also, just looking at the code I'm unsure how it fixes the bug, if it actually does so. Could you confirm that you've tested this based on the steps to repro in the issue https://github.com/middlewarehq/middleware/issues/559, and that it indeed worked for you?
Hey @carmen-cruzarana, let us know if you still intend to work on this. I'd be okay with closing the PR in case you're unable, or don't wish to continue on this for any reason.