middleware icon indicating copy to clipboard operation
middleware copied to clipboard

Add a `Star this repo on Github` button

Open e-for-eshaan opened this issue 1 year ago • 10 comments

Why do we need this ?

There is no CTA on our app for the users to nudge them to star our repo on GitHub. So creating a button that helps this is needed.

Further Comments / References

something like this: image

e-for-eshaan avatar Jul 01 '24 09:07 e-for-eshaan

So for this, should we have the button directly star the repository (using the github api) or should we redirect the user to the repository page (using something like this) ?

sidtohan avatar Jul 20 '24 04:07 sidtohan

@sidtohan the latter. Basically a simple CTA in the sidebar (adhering to the theme of the app), at the bottom of it should be sufficient.

jayantbh avatar Jul 21 '24 18:07 jayantbh

Are you interested in taking this up?

jayantbh avatar Jul 21 '24 18:07 jayantbh

Are you interested in taking this up?

Yes I would be interested in working on this :)

sidtohan avatar Jul 22 '24 03:07 sidtohan

Hey so is there any update on this issue? If it is still in consideration I would like to work on this.

sidtohan avatar Jul 26 '24 16:07 sidtohan

Hey apologies I missed the notification. Sure, feel free to take this up, @sidtohan!

jayantbh avatar Jul 26 '24 16:07 jayantbh

Because this will be a visual change, please share your approach/idea for changes before implementing anything.

jayantbh avatar Jul 26 '24 16:07 jayantbh

image but we already have this in navbar

Ankur1493 avatar Aug 03 '24 09:08 Ankur1493

image but we already have this in navbar

That's a good catch. Do we need this or something different? @jayantbh

sidtohan avatar Aug 04 '24 04:08 sidtohan

Something different is acceptable, @Ankur1493 and @sidtohan

The screenshot shared belongs to the landing page. This issue talks about adding a CTA to the docker app.

jayantbh avatar Aug 04 '24 17:08 jayantbh

@sidtohan been a while, how's are things looking for this?

If you are unable to pick this up, let us know!

e-for-eshaan avatar Aug 26 '24 05:08 e-for-eshaan

@sidtohan been a while, how's are things looking for this?

If you are unable to pick this up, let us know!

Hello,

I am facing an issue with the hardware itself of my laptop. It would not be possible to work on this particular issue, so I would request you to assign this to someone else.

:(

sidtohan avatar Aug 26 '24 05:08 sidtohan

image but we already have this in navbar

That is on our landing page. We also need a similar functionality within Middleware Opensource.

samad-yar-khan avatar Aug 26 '24 07:08 samad-yar-khan

Suggestions? 🤔

Screenshot 2024-08-27 at 4 37 18 PM

Kamlesh72 avatar Aug 27 '24 11:08 Kamlesh72

Hey @Kamlesh72 , not the place i would want it to be. How about the top-right section of the page-headers? cc: @jayantbh

e-for-eshaan avatar Aug 27 '24 12:08 e-for-eshaan

It looks good, but it is very close to loading (can be ignored). If we go with this, should it be shown on every page or just DORA metrics?

Screenshot 2024-08-27 at 7 47 48 PM

Transparent Background 👇🏻 Screenshot 2024-08-27 at 8 11 01 PM

Kamlesh72 avatar Aug 27 '24 14:08 Kamlesh72

Hey @Kamlesh72 , can you raise a PR, so we can start commenting there. Will be easier for me to pick stuff-up for referencing in my comments!

e-for-eshaan avatar Aug 30 '24 07:08 e-for-eshaan

Also, I am assigning this issue to you!

e-for-eshaan avatar Aug 30 '24 07:08 e-for-eshaan

@Kamlesh72 did you manage to raise a PR? You can start with proof-of-concept PR, and then work on it, building and polishing it w.r.t the reviewer-comments.

e-for-eshaan avatar Sep 03 '24 05:09 e-for-eshaan

@e-for-eshaan Not yet. I got some urgent work so was not able to do it, so sorry.

I will make the PR by tonight.

Kamlesh72 avatar Sep 03 '24 06:09 Kamlesh72