middlewarehq
Add Functionality for PRs merged without review
Why do we need this ?
- A team may be interested in seeing how many PRs got merged without review in a time duration.
- This can help in setting processes within the team
Acceptance Criteria
- [ ] Add Python Backend API to fetch Teams PRs merged without review for a team.
- [ ] Update Next JS BFF slices and state to fetch and persist a team PRs merged without review.
- [ ] Add UI component to see PRs merged without review for a team.
Task 1, 2, 3 can be done in seperate PRs.
Further Comments / References
If anyone else is interested in this being a part of the app, please comment or react to the thread. :)
Sure! Do remember that because this will be a visual change, you'll need to clear up the visual changes before implementing them.
We already have an idea of how we want to build this, but you're welcome to pitch your idea of how you see this being built. In case you'd prefer to go with our idea itself, that's totally fine.
Let us know how you want to proceed.
@jayantbh will proceed with your idea and here visual change meant ? , i have not much exp with flask , will work on that and i will have to create a route in pull_requests.py file for fetching the Prs which are not reviewed based on a team_id .
By visual change, I mean that if you see the original issue description, you'll see it talks about a UI change as well. That. 🙂
@jayantbh the settings here is a form of type validation ? , a bit confused with this part any resource i could use to understand it (get_settings service part and type validation process)
@jayantbh the settings here is a form of type validation ? , a bit confused with this part any resource i could use to understand it (get_settings service part and type validation process)
@RISHIKESHk07 get_settings_service() is a getter that fetches the SettingsService after injecting all the dependencies. Here we are first fetching the SettingsService and then fetching a specific setting using get_setting method. The get_setting method fetches a setting for a type and entity. This entity can be a team, user or org as a whole.
@jayantbh @samad-yar-khan , this is my solution for making a backend route , please correct if i it is flawed
(i) create a function merged_not_reviwed in PullRequestAnalyticsService
(ii) create function for filtering data , i would find all ids with type "Review " from PullRequestEvent class then use this list to filter out data from the PullRequest class , return the result
(iii) create a route ('/teams/
I think it doesn't need to be a separate screen. This could be a small widget thing on one of the existing UIs.
If every metric is on its own page it'll be difficult to get the whole picture from any single point.
Alright that does sound better than a whole page , do we use a component lib for styling ? , does the backend route creation look fine ?
I'll let @samad-yar-khan chime in on the API path.
Visually, it can be shown in the lead time/cycle time sidebar beside the CT/LT breakdown, like this:
Hey @samad-yar-khan , @jayantbh This issue sounds interesting to me, Can I work on the UI part of it ?
