middleman-minify-html icon indicating copy to clipboard operation
middleman-minify-html copied to clipboard

Added compress_css and compress_javascript options

Open joost opened this issue 10 years ago • 6 comments

A different approach that would 'always' be compatible would me moving to a option :config that specifies the whole Htmlcompressor config.

joost avatar Feb 09 '15 16:02 joost

Any reason you wouldnt just the normal minify_css and minify_js features?

tdreyno avatar Feb 09 '15 17:02 tdreyno

Hmm it looks like this commit was overwritten at some point, the current docs are out of date.

Arcovion avatar Feb 09 '15 19:02 Arcovion

@Arcovion Whoops, probably my fault when merging the new design.

tdreyno avatar Feb 09 '15 19:02 tdreyno

@tdreyno this is about inline CSS/JS or am I missing something?

joost avatar Feb 09 '15 19:02 joost

@joost Our core minifiers work inline. See the commit @Arcovion referenced above. I think this is just a documentation issue.

tdreyno avatar Feb 09 '15 21:02 tdreyno

I see. Don't get why though:

  • it requires an extra pass over all .html files
  • it requires extra custom code (eg. Middleman::Extensions::MinifyJavascript#minify_inline_content)

Why not just leverage on Htmlcompressor?

joost avatar Feb 10 '15 08:02 joost