middleman-blog icon indicating copy to clipboard operation
middleman-blog copied to clipboard

Missing parent in site herarchy while using tags

Open Jeeppler opened this issue 8 years ago • 4 comments

The middleman-blog extension sets the parent element to nil, if the article is categoriezed by tag.

E. g. recipes -> tag -> lunch -> 03_20_noodles_tomato //03_20_noodles_tomato does not have a parent (expected parent recipes)

recipes -> 03_20_noodles_tomato //the parent is set correctly to recipes

This actually breaks the following extension: https://github.com/marnen/middleman-breadcrumbs

For more details see: https://github.com/marnen/middleman-breadcrumbs/issues/7

Jeeppler avatar Jun 02 '16 06:06 Jeeppler

This is probably because the Tag page is a proxy template

Can you provide some feature tests for this?

I actually wrote the same issue in breadcrumbs : https://github.com/marnen/middleman-breadcrumbs/issues/15

And wrote my own referenced in that link.

iwarner avatar Mar 23 '17 23:03 iwarner

This is probably because the Tag page is a proxy template.

Yes, most likely.

Can you provide some feature tests for this?

I do not understand the question. What would you like me to test?

Jeeppler avatar Mar 24 '17 01:03 Jeeppler

I don't really know if it's related but I'm using middleman-breadcrumbs and I couldn't get the breadcrumb working on tag pages because tags are missing a parent in site hierarchy.

I fixed this quite simply by creating a tags.html.erb page in my blog directory. Now tag pages like /blog/tags/foo.html have a parent that is /blog/tags.html and the breadcrumb works.

I'm leaving this information here in case someone have the same problem.

See this issue that may be related: https://github.com/marnen/middleman-breadcrumbs/issues/15

vinc avatar Nov 21 '17 19:11 vinc

@vinc Yes, this issue is related to it. Interesting that you only had to create a tags.html.erb file.

Jeeppler avatar Nov 30 '17 00:11 Jeeppler