msgraph-sdk-powershell icon indicating copy to clipboard operation
msgraph-sdk-powershell copied to clipboard
verified publisher icon microsoftgraph

Connect-Graph Enhancements - Metaissue

Open darrelmiller opened this issue 5 years ago • 5 comments

Related to issues: #125 , #123, #102, #46, #52, #113 AB#7439

darrelmiller avatar Mar 17 '20 14:03 darrelmiller

I would rename Connect-Graph to Connect-MgService. This makes a bit more sense than Connect-MgGraph (Connect Microsoft Graph Graph?) and Connect-MgAccount since we're connecting to the Microsoft Graph service and not a reference to an account.

Plus it would be like the SPO cmdlets and hopefully would start a movement to get other services to adopt the same format :-)

ghost avatar Mar 18 '20 02:03 ghost

@tseward Thanks for your input. I shopped the "service" suffix around a bit and the feedback is that the term is a bit overloaded and it conflicts with some of the other work that is going on. There wasn't much enthusiasm for the Account suffix and there wasn't much objection to Connect-MgGraph. So for the moment, we are planning to go with Connect-MgGraph and alias Connect-Graph so that we don't break existing folks.

darrelmiller avatar Mar 18 '20 19:03 darrelmiller

Parameter Delegated Application-Only MSI Plan
-Scopes X    
-TenantId X X  
-ClientId (ApplicationId)   X  Alias ApplicationId
-CertificateName   X  
-CertificateThumbprint   X  
-ForceRefresh X X  
-AccessToken ? ? ? GA
-Credential   ?  Post V1
-Environment X X X Post V1
-Identity     X Waiting for Graph Core 2
-Certificate   ?   Post V1
-ContextName ? ? No decision
-UseDeviceCode ?    GA Default in Linux, Option in Windows

darrelmiller avatar Mar 18 '20 19:03 darrelmiller

On my work machine I have a number of Connect-* commandlets. Here are a few:

  • Connect-AzureAD <-- only the module prefix of "AzureAD"
  • Connect-SPOService <-- prefix + "Service", already mentioned above
  • Connect-AzAccount <-- prefix + "Account", not really notion of Account in Graph
  • Connect-PnPOnline <-- prefix + "Online", to distinguish from on-prem SharePoint
  • Connect-ExchangeOnline <-- not the prefix nor an alias, module then uses "EXO" as prefix

Using the prefix + something seems to be the norm (at least for MSFT created modules). I would be in favor of these:

  • Connect-Mg with alias to Connect-Graph
  • Connect-MgGraph with alias Connect-Graph

BrianTJackett avatar Mar 31 '20 17:03 BrianTJackett

support for interactive credential by default on windows.

ddyett avatar Jul 08 '20 18:07 ddyett

Closing this since all enhancements were addressed.

maisarissi avatar Sep 29 '22 19:09 maisarissi