msgraph-sdk-php icon indicating copy to clipboard operation
msgraph-sdk-php copied to clipboard

SignInsRequestBuilderGetRequestConfiguration $queryParameters->filter is really doing case sensitive $filter

Open Teejer opened this issue 1 year ago • 2 comments

Describe the bug

When doing a query for signins for users it is doing a case sensitive search, $filter, instead of the case insensitive search, filter. I got the following from fiddler. https://graph.microsoft.com/v1.0/auditLogs/signIns?$filter=userPrincipalName%20eq%20%27user%40place.com%27&$top=5

Because of this, results don't come back when they are expected.

per https://learn.microsoft.com/en-us/odata/concepts/queryoptions-overview#system-query-options

case sensitive is $filter case insensitive is filter.

Here is the code I am using.

$requestConfiguration = new SignInsRequestBuilderGetRequestConfiguration(); $queryParameters = SignInsRequestBuilderGetRequestConfiguration::createQueryParameters(); $queryParameters->filter = "userPrincipalName eq '".$username."'"; $queryParameters->top = 5; $requestConfiguration->queryParameters = $queryParameters;

If this is by design, how would someone do a case insensitive search? AKA https://graph.microsoft.com/v1.0/auditLogs/signIns?filter=userPrincipalName%20eq%20%27user%40place.com%27&$top=5

Expected behavior

results to be returned

How to reproduce

mix case on a upn in the https://graph.microsoft.com/v1.0/auditLogs/signIns space

SDK Version

2.11.0

Latest version known to work for scenario above?

No response

Known Workarounds

make sure you match case.

Debug output

Click to expand log ```
</details>


### Configuration

_No response_

### Other information

_No response_

Teejer avatar Aug 28 '24 16:08 Teejer

Thank you for this feedback @Teejer.

For a temporary workaround, you can use the withUrl method and pass the full request URL:


$graphServiceClient->auditLogs()->signIns()->withUrl(
    "https://graph.microsoft.com/v1.0/auditLogs/signIns?filter=userPrincipalName%20eq%20%27user%40place.com%27&$top=5"
)->get();

Ndiritu avatar Sep 03 '24 08:09 Ndiritu

thank you for working on this.

Teejer avatar Sep 03 '24 14:09 Teejer