msgraph-sdk-java-auth icon indicating copy to clipboard operation
msgraph-sdk-java-auth copied to clipboard

Concurrent use not accounted for in authentication providers

Open davidmoten opened this issue 5 years ago • 2 comments

The sdk could easily be in use from multiple threads in an application. To keep new token requests to a minimum one approach is simply to add a synchronized keyword to UsernamePasswordProvider.getAccessToken() and other other providers in this project. AB#7115

davidmoten avatar Feb 25 '20 05:02 davidmoten

Thank you @davidmoten. We are adding this to our backlog to be considered when we have resources focused on this again.

MIchaelMainer avatar Feb 27 '20 21:02 MIchaelMainer

Hi @davidmoten Thanks for reaching out and for the patience. With the release of the v3 of the java SDK, it now integrates with Azure Identity which supports a wide variety of authentication flows out of the box. We strongly encourage you to migrate to this v3 + azure identity, and you can read more about it in this issue. https://github.com/microsoftgraph/msgraph-sdk-java/issues/628

This issue won't be fixed, but I'll leave it open for visibility, and the repository will be archived soon.

baywet avatar Mar 16 '21 12:03 baywet