msgraph-sdk-dotnet icon indicating copy to clipboard operation
msgraph-sdk-dotnet copied to clipboard

'Person' missing from EntityType.cs

Open daviesro opened this issue 2 years ago • 3 comments

Entity type 'Person' is missing from the generated model EntityType.cs. Example usage below:

var requests = new List<SearchRequestObject>()
{
    new SearchRequestObject
    {
        EntityTypes = new List<EntityType>
        {
            EntityType.Person // Does not exist
        },
        Query = new SearchQuery
        {
           QueryString = "foobar"
        },
        Size = 5,
    }
};

daviesro avatar Feb 23 '22 21:02 daviesro

Hey @daviesro,

Thanks for raising this.

We will follow this up with the relevant workload team so that the metadata can be updated to include the missing member and circle back to give you feedback on this.

andrueastman avatar Feb 25 '22 06:02 andrueastman

Hey @daviesro,

The feedback so far is that the Entity type 'Person' is only available in beta at the moment and is the testing phases before becoming generally available and moving to v1.0.

Just to confirm, are you able to use this on v1.0? or did you intend to create the issue on the beta repository?

andrueastman avatar Mar 02 '22 08:03 andrueastman

Hey @daviesro,

The feedback so far is that the Entity type 'Person' is only available in beta at the moment and is the testing phases before becoming generally available and moving to v1.0.

Just to confirm, are you able to use this on v1.0? or did you intend to create the issue on the beta repository?

Hey @andrueastman,

I am able to use this on v1.0, yeah. It also seems useable on v1.0 on the Graph Explorer, too. Request body, targeting 'https://graph.microsoft.com/v1.0/search/query':

{
    "requests": [
        {
            "entityTypes": [
                "person"
            ],
            "query": {
                "queryString": "daviesro"
            }
        }
    ]
}

Redacted user information from response, but odata.context shows 'v1.0':

    "@odata.context": "https://graph.microsoft.com/v1.0/$metadata#Collection(microsoft.graph.searchResponse)",
    "value": [
        {
            "hitsContainers": [
                {
                    "total": 2,

daviesro avatar Mar 02 '22 09:03 daviesro

Closing this one for now as the metadata has been updated and the enum property available in V5 versions of the SDK

https://github.com/microsoftgraph/msgraph-sdk-dotnet/blob/9eccc47e2900ec67fb1e11e7885fef93debcf578/src/Microsoft.Graph/Generated/Models/EntityType.cs#L13

andrueastman avatar Mar 10 '23 08:03 andrueastman