msgraph-metadata icon indicating copy to clipboard operation
msgraph-metadata copied to clipboard

Many items are not marked as deprecated

Open Licantrop0 opened this issue 2 years ago • 2 comments

in Graph OpenAPI.yaml I found these items containing "deprecated" in the description, but without deprecated property set:

Entities: microsoft.graph.windowsPackageInformation

Operations: agreements.GetFiles agreements.ListFiles communications.ListOnlineMeetings identityGovernance.termsOfUse.agreements.GetFiles identityGovernance.termsOfUse.agreements.ListFiles me.ListOnlineMeetings schemaExtensions.schemaExtension.ListSchemaExtension users.ListOnlineMeetings

Properties: microsoft.graph.agreement,files microsoft.graph.androidFotaDeploymentAssignment,assignmentTarget microsoft.graph.androidLobApp,identityName microsoft.graph.androidLobApp,identityVersion microsoft.graph.conditionalAccessConditionSet,clientAppTypes microsoft.graph.conditionalAccessConditionSet,deviceStates microsoft.graph.customSecurityAttributeDefinition,status microsoft.graph.deviceManagement.alertRule,threshold microsoft.graph.iosDeviceFeaturesConfiguration,singleSignOnExtension microsoft.graph.iosGeneralDeviceConfiguration,enterpriseAppBlockTrustModification microsoft.graph.iosGeneralDeviceConfiguration,kioskModeAllowAutoLock microsoft.graph.iosGeneralDeviceConfiguration,kioskModeAllowRingerSwitch microsoft.graph.iosGeneralDeviceConfiguration,kioskModeAllowScreenRotation microsoft.graph.iosGeneralDeviceConfiguration,kioskModeAllowSleepButton microsoft.graph.iosGeneralDeviceConfiguration,kioskModeAllowTouchscreen microsoft.graph.iosGeneralDeviceConfiguration,kioskModeAllowVolumeButtons microsoft.graph.macOSDeviceFeaturesConfiguration,associatedDomains microsoft.graph.macOSDeviceFeaturesConfiguration,singleSignOnExtension microsoft.graph.managedAndroidLobApp,identityName microsoft.graph.managedAndroidLobApp,identityVersion microsoft.graph.microsoftTunnelConfiguration,routesExclude microsoft.graph.microsoftTunnelConfiguration,routesInclude microsoft.graph.plannerTaskCreation,teamsPublicationInfo microsoft.graph.recommendationBase,recommendationType microsoft.graph.remoteActionAudit,userName microsoft.graph.rolePermission,actions microsoft.graph.schemaExtension,status microsoft.graph.security.ediscoveryExportOperation,exportOptions microsoft.graph.servicePrincipal,errorUrl microsoft.graph.subscription,latestSupportedTlsVersion microsoft.graph.unifiedRoleAssignment,resourceScope microsoft.graph.unifiedRoleDefinition,resourceScopes microsoft.graph.windows10EndpointProtectionConfiguration,deviceGuardEnableSecureBootWithDMA microsoft.graph.windows10GeneralConfiguration,smartScreenEnableAppInstallControl microsoft.graph.windowsAutopilotDeviceIdentity,azureActiveDirectoryDeviceId

moreover, some of the entities (e.g. accessReviewDecision) are marked as deprecated in the Docs but no deprecated property is set in the original CSDL.

Licantrop0 avatar Nov 22 '23 19:11 Licantrop0

thanks for creating this. For information microsoft.graph.subscription,latestSupportedTlsVersion is a false positive, and we should be careful about that aspect when considering the other ones.

baywet avatar Nov 23 '23 14:11 baywet

thanks for creating this. For information microsoft.graph.subscription,latestSupportedTlsVersion is a false positive, and we should be careful about that aspect when considering the other ones.

Yes, I was only comparing if the description contained the word "deprecated", not the exact meaning of the description.
We should double-check all properties.

Licantrop0 avatar Nov 27 '23 19:11 Licantrop0