msgraph-beta-sdk-dotnet icon indicating copy to clipboard operation
msgraph-beta-sdk-dotnet copied to clipboard

Missing property includeTargets on fido2AuthenticationMethodConfiguration resource type from Beta version 5.54.0 and onwards

Open edwinvandriel opened this issue 2 years ago • 8 comments

When upgrading the graph beta sdk from version 5.53.0 to the latest it breaks on the property includeTargets from the fido2AuthenticationMethodConfiguration type. The property disappears from version 5.54.0-preview and onwards.

The docs says it still should exist https://learn.microsoft.com/en-us/graph/api/resources/fido2authenticationmethodconfiguration?view=graph-rest-beta

Hope this can be fixed soon, breaking change for us.

edwinvandriel avatar Dec 14 '23 12:12 edwinvandriel

Metadata available at https://graph.microsoft.com/beta/$metadata used to generate the SDK is also missing the the navigation property. image

We will need to confirm if this is a documentation issue or a mistake in the metadata.

@edwinvandriel Any chance you can confirm that the relevant data is still returned/retrievable from the API?

andrueastman avatar Dec 14 '23 13:12 andrueastman

I can confirm it is still relevant. Think it's a mistake in the metadata. The call is https://graph.microsoft.com/beta/policies/authenticationMethodsPolicy/AuthenticationMethodConfigurations/fido2

image

edwinvandriel avatar Dec 14 '23 14:12 edwinvandriel

@andrueastman any news on this one?

edwinvandriel avatar Jan 05 '24 10:01 edwinvandriel

The metadata was updated to have the includeTargets property to target a new derived type of authenticationMethodTarget that is not publicly and therefore stripped out of the final metadata.

We're following up with the workload team on whether the removal of the property was intended here.

andrueastman avatar Jan 15 '24 09:01 andrueastman

Why should a removal be intended without a notice? It's a functionality that is also available in de v1 productions metadata. Could there be some more prio. It's now 6 weeks ago that i've been able to update the sdk :-(

edwinvandriel avatar Jan 30 '24 11:01 edwinvandriel

@andrueastman why isn't this solved yet?

edwinvandriel avatar Mar 04 '24 09:03 edwinvandriel

API team is working on fixing the metadata on this one and should be resolved once the updated metadata is deployed in the coming week.

andrueastman avatar Mar 18 '24 10:03 andrueastman

@andrueastman any update on this one? Still broken...

edwinvandriel avatar Apr 04 '24 08:04 edwinvandriel

This has finally been fixed, as of https://github.com/microsoftgraph/msgraph-metadata/pull/623/commits/2329c74dc88c4bd0c0f0fc72bdc1faa95c7c40bf

It's supposed to be in the next NuGet release.

tlrdstd avatar May 17 '24 13:05 tlrdstd

Closing this one for now as the property was added via https://github.com/microsoftgraph/msgraph-beta-sdk-dotnet/pull/843 and available in the release at https://github.com/microsoftgraph/msgraph-beta-sdk-dotnet/releases/tag/v5.76.0-preview

andrueastman avatar May 24 '24 06:05 andrueastman