microsoft-graph-toolkit icon indicating copy to clipboard operation
microsoft-graph-toolkit copied to clipboard

feat: add custom element disambiguation

Open gavinbarron opened this issue 1 year ago • 5 comments

Closes #1765

PR Type

Feature

Description of the changes

Adds the ability for developers to add a custom segment to the custom elements registered with the browser. Provides a new customElement decorator to wrap the lit implementation and set tag prefixes appropriately. Updates all usages of customElement to use the mgt specific implementation Adds a new mgtHtml string literal tag function to dynamically rewrite mgt tags as needed at runtime which wraps the html tag function from lit Updates SCSS to avoid using element name based CSS selectors and adds classes to elements in markup where needed. Updates React generator script to use base tag names. Updates Mgt React wraper to add the appropriate prefix to tags being written to the DOM. Updates React sample app to demonstrate usage of customElementHelper.withDisambiguation('foo').

PR checklist

  • [x] Project builds (yarn build) and changes have been tested in at least two supported browsers (Edge + non-Chromium based browser)
  • [x] All public APIs (classes, methods, etc) have been documented following the jsdoc syntax
  • [ ] Stories have been added and existing stories have been tested
  • [ ] Added appropriate documentation. Docs PR:
  • [x] License header has been added to all new source files (yarn setLicense)
  • [x] Contains NO breaking changes

Other information

gavinbarron avatar Sep 09 '22 16:09 gavinbarron

The updated storybook is available here

github-actions[bot] avatar Sep 09 '22 18:09 github-actions[bot]

The updated storybook is available here

github-actions[bot] avatar Sep 09 '22 22:09 github-actions[bot]

The updated storybook is available here

github-actions[bot] avatar Sep 12 '22 07:09 github-actions[bot]

The updated storybook is available here

github-actions[bot] avatar Sep 22 '22 00:09 github-actions[bot]

The updated storybook is available here

github-actions[bot] avatar Sep 22 '22 17:09 github-actions[bot]

The updated storybook is available here

github-actions[bot] avatar Oct 18 '22 23:10 github-actions[bot]

The updated storybook is available here

github-actions[bot] avatar Oct 20 '22 15:10 github-actions[bot]

The updated storybook is available here

github-actions[bot] avatar Oct 25 '22 21:10 github-actions[bot]