microsoft-graph-toolkit icon indicating copy to clipboard operation
microsoft-graph-toolkit copied to clipboard

Missing localization for contact parts in PersonCard

Open lebiku opened this issue 1 year ago • 1 comments

We have been localizing the person card. I didn't find translation support for the contact detail information though. I checked the code and realized those string are hard-coded. Could you please add localization support for those labels too.

lebiku avatar Sep 05 '22 10:09 lebiku

Hello lebiku, thank you for opening an issue with us!

I have automatically added a "needs triage" label to help get things started. Our team will analyze and investigate the issue, and escalate it to the relevant team if possible. Other community members may also look into the issue and provide feedback 🙌

msftbot[bot] avatar Sep 05 '22 10:09 msftbot[bot]

Hello @lebiku could you clarifyfor me, is this the part that you're referring to?

image

musale avatar Oct 04 '22 10:10 musale

Hello @musale Yes, it's exactely those parts. Thank you for investigation.

lebiku avatar Oct 04 '22 18:10 lebiku

Hello @musale Yes, it's exactely those parts. Thank you for investigation.

Great. I have put up a PR for it. You can check out the built storybook to test.

musale avatar Oct 05 '22 08:10 musale