microsoft-graph-toolkit icon indicating copy to clipboard operation
microsoft-graph-toolkit copied to clipboard

feature: Update teams-channel-picker to fluent UI designs

Open musale opened this issue 1 year ago • 9 comments

Closes #1202

PR Type

  • Feature

Description of the changes

Updates the teams channel picker component to the new fluent UI designs. Designs can be found here

PR checklist

  • [x] Project builds (yarn build) and changes have been tested in at least two supported browsers (Edge + non-Chromium based browser)
  • [x] All public APIs (classes, methods, etc) have been documented following the jsdoc syntax
  • [x] Stories have been added and existing stories have been tested
  • [ ] Added appropriate documentation. Docs PR:
  • [ ] License header has been added to all new source files (yarn setLicense)
  • [ ] Contains NO breaking changes

Other information

Initial work done on this update has been closed in favor of this.

musale avatar Aug 15 '22 10:08 musale

Thank you for creating a Pull Request @musale.

This is a checklist for the PR reviewer(s) to complete before approving and merging this PR:

  • [ ] I have verified a documentation PR has been linked and is approved (or not applicable)
  • [ ] I have ran this PR locally and have tested the fix/feature
  • [ ] I have verified that stories have been added to storybook (or not applicable)
  • [ ] I have tested existing stories in storybook to verify no regression has occured
  • [ ] I have tested the solution in at least two browsers (Edge + 1 non-Chromium based browser)

msftbot[bot] avatar Aug 15 '22 10:08 msftbot[bot]

The updated storybook is available here

github-actions[bot] avatar Aug 22 '22 10:08 github-actions[bot]

@musale this looks beautiful, but I can't use my keyboard to select anything in the list now :(

gavinbarron avatar Aug 23 '22 21:08 gavinbarron

The updated storybook is available here

github-actions[bot] avatar Aug 23 '22 22:08 github-actions[bot]

Can we expand a group when we get hits within it due to a search? Having the groups collapsed is a bit of a regression from the previous behavior. image

gavinbarron avatar Aug 24 '22 16:08 gavinbarron

@musale this looks beautiful, but I can't use my keyboard to select anything in the list now :(

Let me investigate this, thank you.

musale avatar Aug 31 '22 09:08 musale

Can we expand a group when we get hits within it due to a search? Having the groups collapsed is a bit of a regression from the previous behavior. image

Yes, I have done a POC and it's working. Furnishing some rough edges then I update it.

musale avatar Sep 01 '22 09:09 musale

The updated storybook is available here

github-actions[bot] avatar Sep 01 '22 12:09 github-actions[bot]

The updated storybook is available here

github-actions[bot] avatar Sep 02 '22 10:09 github-actions[bot]

The updated storybook is available here

github-actions[bot] avatar Sep 26 '22 12:09 github-actions[bot]

The updated storybook is available here

github-actions[bot] avatar Sep 26 '22 12:09 github-actions[bot]

The updated storybook is available here

github-actions[bot] avatar Oct 17 '22 15:10 github-actions[bot]

I suggest scheduling a design review on the component. There are a couple of behaviors I'm unsure of and I think we should meet!

sebastienlevert avatar Oct 18 '22 14:10 sebastienlevert

The updated storybook is available here

github-actions[bot] avatar Oct 21 '22 10:10 github-actions[bot]

Nice work @musale, It's getting better with the keyboard, now I can tab from the input field to the filtered tree view. Can we add a key down handler that traps on DownArrow to also set the focus to the first element in the tree?

We need to ensure that backspace or delete when there is no input text and there is a selectedChannel clears the selectedChannel.

In our design review we should drill into the user flows for keyboard users after selecting a channel as at the moment there is no means to change the selected channel at all based on my testing.

gavinbarron avatar Oct 21 '22 15:10 gavinbarron