microsoft-graph-toolkit icon indicating copy to clipboard operation
microsoft-graph-toolkit copied to clipboard

[BUG][Feature request] TeamsMsal2Provider - unable to catch the error/exception happening while trying to login using SSO with TeamsMsal2Provider

Open ARsquare opened this issue 2 years ago • 2 comments

Describe the bug TeamsMsal2Provider uncaught (promise) from constructor when ssourl configured when ssourl call fails. When constructing TeamsMsal2Provider it calls async internalLogin() if ssoUrl is configured. Exceptions from internalLogin are not handled. Is there a way to determine authentication failed?

To Reproduce Steps to reproduce the behavior: let teamsMsal2Config = { ..., httpMethod: HttpMethod.POST, ssoUrl: "https://ssoUrl/, }; const teamsMsal2Provider = new TeamsMsal2Provider(teamsMsal2Config);

Expected behavior Get notified about the exception/ error that happened while trying to login

Screenshots Screenshot 2022-05-05 at 12 23 33 AM

Environment (please complete the following information):

OS: Mac Browser chrome Framework react Context Microsoft Teams Version 2.3.2 Provider TeamsMsal2Provider

ARsquare avatar May 04 '22 18:05 ARsquare

Hello ARsquare, thank you for opening an issue with us!

I have automatically added a "needs triage" label to help get things started. Our team will analyze and investigate the issue, and escalate it to the relevant team if possible. Other community members may also look into the issue and provide feedback 🙌

ghost avatar May 04 '22 18:05 ghost

https://github.com/microsoftgraph/microsoft-graph-toolkit/issues/1478

isvargasmsft avatar May 05 '22 20:05 isvargasmsft

closing this as the Teams MSAL2 Provider has been deprecated, please use the TeamsFX provider

gavinbarron avatar Jul 20 '23 00:07 gavinbarron