microsoft-graph-explorer-v4 icon indicating copy to clipboard operation
microsoft-graph-explorer-v4 copied to clipboard

Text not centered

Open RabebOthmani opened this issue 2 years ago • 1 comments

Both on the Toolkit Component tab and the Adaptive Cards tab, when a component/card is not available, the text appearing on the screen is not centered forcing the user sometimes to scroll while there's enough space . adaptive card text MGT text

RabebOthmani avatar Aug 10 '22 15:08 RabebOthmani

@RabebOthmani do you want these centered vertically and horizontally? The text block in Toolkit component view appears to be centered vertically, but not horizontally, while the adaptive card element looks about right horizontally but not vertically to my eye.

gavinbarron avatar Aug 10 '22 15:08 gavinbarron

@gavinbarron agree on the adaptive cards. Actually, do we even want it to be horizontally centered? I'm concerned a user might need to scroll to eventually read a text telling them what they need is not available. We might just want this to be top left . Thoughts? Also the toolkit text on expand : MGT tab on expand

RabebOthmani avatar Aug 11 '22 16:08 RabebOthmani

Not a designer, but I'd go for those text elements being centered on the x but at the top of the y using a flexbox and the text having width 100% and with some padding from the container ensure that if you hit the wrap length there's equal spacing on the left and right.

Related question, does GE support RTL languages?

gavinbarron avatar Aug 11 '22 16:08 gavinbarron