microsoft-graph-explorer-v4 icon indicating copy to clipboard operation
microsoft-graph-explorer-v4 copied to clipboard

[Auto-Complete] Hide the 'more info' button

Open RabebOthmani opened this issue 2 years ago • 12 comments

Will hide for now until we rethink the info we want to provide there.

RabebOthmani avatar May 31 '22 12:05 RabebOthmani

@RabebOthmani any particular reason why this feature needs to be hidden ? I personally use it to discover the documentation for queries ie it shortens the journey of having to look for documentation related to a particular query. My recommendation is that we add telemetry for this feature and see the current usage metrics around it

adhiambovivian avatar Jun 23 '22 08:06 adhiambovivian

@adhiambovivian The button only works to discover documentation for ~1% of Graph URLs. If the user happens to try it on a URL that does work, it sets the user up with the false expectation that it will work for all URLs and then they will find that it doesn't work for almost everywhere.

darrelmiller avatar Jun 23 '22 14:06 darrelmiller

@thewahome as per my comment above, I want us to hide the button temporarily until we have a complete picture of what it should look like and do. Currently, as an example if I have https://graph.microsoft.com/v1.0/me/activities and I click on the info button nothing happens. I can see that you logged an issue to surface the documentation . I'd rather we ensure we have the documentation before setting false expectations for the user.

RabebOthmani avatar Jun 23 '22 14:06 RabebOthmani

@ddyett Can we get your perspective here?

darrelmiller avatar Jun 27 '22 15:06 darrelmiller

I'm not a fan of pulling a feature in production especially without knowing if anyone leverages it. At this point this has been out for a while. How about treating it like an experiment and adding indication that this is experimental and may not always work reliably. Then as this is now live prioritize above any other feature work adding in the telemetry to validate the experiment. Then you can determine that the feature usage for this is so low we are deprecating it quickly or not. Also gives anyone using this regularly at this point indication we might deprecate.

Does it work for the top 50-100 most used urls?

ddyett avatar Jun 28 '22 00:06 ddyett

It only works for urls that happen to have been used in samples, and if the sample includes a doc URL.

I understand the reluctance to remove a feature in prod, but it is not clear to me what this feature is for. As far as I know it was never spec'd out and discussed by the team. I would have expected us to add doc links to resource explorer as is currently done in the samples tree. Taking up real-estate in the url textbox is less than ideal considering how limited the space is already.

If we really do want to keep it, can we at least fix the overlapping border when we hover over the (i) symbol. It currently appears broken.

darrelmiller avatar Jun 28 '22 22:06 darrelmiller

@darrelmiller I've added telemetry to help us see how useful it is so that it is easy to make that decision.

I can work on the border so that it doesn't overlap the way it does

thewahome avatar Jun 29 '22 05:06 thewahome

@thewahome Great, thanks. Can you help me understand how the telemetry is setup to enable our decision as to whether this is the best place to expose documentation links?

darrelmiller avatar Jul 05 '22 14:07 darrelmiller

@darrelmiller there is telemetry collected when someone clicks the more info button that launches the popup. The click together with a sanitised URL is collected so that we can know what URLs make people curious about the other information available

thewahome avatar Jul 06 '22 10:07 thewahome

@ddyett when on Resource Explorer and I select a query, the query box gets populated and the button is disabled. If I'm using autocomplete and adding anything after /me for example , the button is disabled and not doing anything disabled info

RabebOthmani avatar Jul 06 '22 17:07 RabebOthmani

Hi @adhiambovivian , I'm not clear on the reason why this ticket moved to parked. Can you please help me out? This is part of the auto-complete set of work and it's important to be done to be able to ship auto-complete.

RabebOthmani avatar Jul 14 '22 15:07 RabebOthmani

Can we please see the telemetry on this? This is a confusing experience and the behavior of the button is inconsistent (sometimes nothing happens when I click on the info icon).

kristenwomack avatar Aug 17 '22 21:08 kristenwomack

We will do #2150 to confirm how the button is doing

thewahome avatar Oct 13 '22 08:10 thewahome