microsoft-graph-comms-samples icon indicating copy to clipboard operation
microsoft-graph-comms-samples copied to clipboard

Published 20 hours ago • verified publisher icon microsoftgraph

Chores for undeprecating AksSamples

Open InDieTasten opened this issue 1 year ago • 5 comments

  • [x] Update chart yamls to support currently GA supported k8s version
  • [x] Update usage of dependency charts, like ingress-nginx and cert-manager
  • [x] Update Dockerfile to using Windows Server 2022 (current default for deploying nodes in AKS)
  • [x] Update to ~~.NET 6~~ .NET 8 :)
  • [x] Update nuget dependencies
  • [x] Restructure code to adhere to new paradigms coming with .NET 6, such as replacing singleton pattern with dependency injection, changes to web host creation and similar
  • [x] Update docs for provisioning and deployment
  • [x] Add Actions workflow CI for build validation and unit test runs
  • [x] Remove (Deprecated) folder name suffix
  • [x] (Remove useless ghost docs?)

@samarthasthana My company is currently evaluating to do these steps for the eco-system. If they decide to go with it and providing we deliver same or higher quality than the current sample, would you be open for merging our efforts into this repo? This would also resolve the numerous auto PRs from dependabot that are currently open.

InDieTasten avatar Oct 24 '23 14:10 InDieTasten

Hi @InDieTasten, I would be happy to review any changes to the sample that help make them better. We would love for community contributions and activity on this. Thanks.

Public contributed samples would need to live under Public Sample Space

samarthasthana avatar Oct 25 '23 14:10 samarthasthana

@samarthasthana We've got approval from our end to do this and we will be working on an up-to-date sample for running a recording bot on AKS.

Are there any other kinds of rules that we need to be aware of when submitting the public sample apart from the contributing guidelines? Limitations on third party dependencies? Commit message style? Coverage? Licensing limitations?

InDieTasten avatar Nov 06 '23 09:11 InDieTasten

❗ For anyone looking to utilize the sample or even help in this endeavor, please contact me. Our current progress towards this item can be looked at over on our fork: https://github.com/LM-Development/aks-sample

InDieTasten avatar Jan 22 '24 15:01 InDieTasten

I would be happy to review any changes to the sample that help make them better. We would love for community contributions and activity on this. Thanks.
@samarthasthana

The draft PR is up :)

InDieTasten avatar Apr 18 '24 08:04 InDieTasten

@samarthasthana The PR has been promoted to "Ready for review" last week. Please feel free to review the new sample and request changes where needed

InDieTasten avatar May 15 '24 11:05 InDieTasten