xdp-for-windows icon indicating copy to clipboard operation
xdp-for-windows copied to clipboard

Native XDP versioning

Open MilesPennerIntel opened this issue 2 years ago • 2 comments

As the Native XDP is built into the NDIS miniports, can we request the addition of a runtime version check so the NDIS miniport can determine the version of XDP on the host vs. what is compiled into the NDIS miniport.

The reason for the request is so we can version check the structures or determine if we have can support the feature while the NDIS driver is initializing.

MilesPennerIntel avatar Feb 22 '23 19:02 MilesPennerIntel

This should already exist, though it is not documented nor included in the sample code: the XdpGetDriverApiVersion function can be called from the interface's optional XDP_OPEN_INTERFACE callback that gets invoked by XDP during the XDP<->NIC binding process.

Note that because XDP is not included in the Windows image and is designed to support fully dynamic servicing (i.e. the XDP driver can be stopped, upgraded, and restarted without restarting any NICs) this XDP_OPEN_INTERFACE callback can be invoked any time (or multiple times) after the NIC has registered with XdpRegisterInterface. This implies we cannot provide a version check at the time of miniport restart.

mtfriesen avatar Feb 24 '23 22:02 mtfriesen

Great thank you Nick. I was just checking the version check out, sorry I missed it before. I see your point about how the XDP LWF driver and application can change while the NDIS miniport is loaded. I will work with my team on this expectation.

MilesPennerIntel avatar Feb 24 '23 22:02 MilesPennerIntel