winget-pkgs icon indicating copy to clipboard operation
winget-pkgs copied to clipboard

New package: ovsky.ADB.Fastboot version 2.9.5

Open ovsky opened this issue 1 year ago • 20 comments

Checklist for Pull Requests

Manifests

  • [x] Have you checked that there aren't other open pull requests for the same manifest update/change?
  • [x] This PR only modifies one (1) manifest
  • [x] Have you validated your manifest locally with winget validate --manifest <path>?
  • [x] Have you tested your manifest locally with winget install --manifest <path>?
  • [x] Does your manifest conform to the 1.9 schema?

Note: <path> is the directory's name containing the manifest you're submitting.


Microsoft Reviewers: Open in CodeFlow

ovsky avatar Jan 13 '25 05:01 ovsky

Service Badge  Service Badge  

wingetbot avatar Jan 13 '25 05:01 wingetbot

/AzurePipelines run

wingetbot avatar Jan 13 '25 05:01 wingetbot

/AzurePipelines run

wingetbot avatar Jan 13 '25 16:01 wingetbot

/AzurePipelines run

wingetbot avatar Jan 13 '25 16:01 wingetbot

/AzurePipelines run

wingetbot avatar Jan 13 '25 16:01 wingetbot

I've fixed and updated the version to properly handle --silent parameters and add more fixes...

ovsky avatar Jan 13 '25 16:01 ovsky

/AzurePipelines run

wingetbot avatar Jan 13 '25 18:01 wingetbot

/AzurePipelines run

wingetbot avatar Jan 13 '25 18:01 wingetbot

/AzurePipelines run

wingetbot avatar Jan 13 '25 18:01 wingetbot

/AzurePipelines run

wingetbot avatar Jan 13 '25 18:01 wingetbot

Manifest: The manifest file path must match PackageIdentifier and PackageVersion properties from manifest. actual 'manifests\o\ovsky\ADB-Fastboot++\2.8.5', expected 'manifests\o\ovsky\ADB\AFI\2.9.5'

stephengillie avatar Jan 13 '25 21:01 stephengillie

/AzurePipelines run

wingetbot avatar Jan 14 '25 10:01 wingetbot

Manifest: The manifest file path must match PackageIdentifier and PackageVersion properties from manifest. actual 'manifests\o\ovsky\ADB-Fastboot++\2.8.5', expected 'manifests\o\ovsky\ADB\AFI\2.9.5'

@stephengillie fixed

ovsky avatar Jan 14 '25 10:01 ovsky

/AzurePipelines run

wingetbot avatar Jan 14 '25 12:01 wingetbot

/AzurePipelines run

wingetbot avatar Jan 14 '25 14:01 wingetbot

/AzurePipelines run

wingetbot avatar Jan 14 '25 16:01 wingetbot

Manifest: The filename must match the PackageIdentifier and ManifestType properties from the manifest. actual 'ovsky.ADB-Fastboot++.yaml', expected 'ovsky.ADB.AFI.yaml'

Not sure why this wasn't caught with the previous.

stephengillie avatar Jan 14 '25 18:01 stephengillie

Manifest: The filename must match the PackageIdentifier and ManifestType properties from the manifest. actual 'ovsky.ADB-Fastboot++.yaml', expected 'ovsky.ADB.AFI.yaml'

Not sure why this wasn't caught with the previous.

Fixed

ovsky avatar Jan 15 '25 14:01 ovsky

At least 1 approving review is required by reviewers with write access.

@stephengillie please check when you can.

ovsky avatar Jan 16 '25 10:01 ovsky

/AzurePipelines run

wingetbot avatar Jan 16 '25 10:01 wingetbot

@wingetbot run

stephengillie avatar Jan 17 '25 01:01 stephengillie

/AzurePipelines run

wingetbot avatar Jan 17 '25 01:01 wingetbot

Edit: Apologies for troubleshooting.

stephengillie avatar Jan 17 '25 18:01 stephengillie

Automatic Validation ended with:

(Automated response - build 943.)

stephengillie avatar Jan 17 '25 19:01 stephengillie

Automatic Validation ended with:

(Automated response - build 943.)

stephengillie avatar Jan 17 '25 19:01 stephengillie

/AzurePipelines run

wingetbot avatar Jan 20 '25 18:01 wingetbot

@wingetbot run

ItzLevvie avatar Jan 20 '25 23:01 ItzLevvie

/AzurePipelines run

wingetbot avatar Jan 20 '25 23:01 wingetbot

@ItzLevvie what about review? Everything passed.

ovsky avatar Jan 23 '25 13:01 ovsky

Hi @ovsky,

The installer seems to not have modified the filesystem. In my VM, i don't see any changed files matching "fastboot".

stephengillie avatar Jan 24 '25 20:01 stephengillie