winget-pkgs icon indicating copy to clipboard operation
winget-pkgs copied to clipboard

New package: KhronosGroup.VulkanSDK version 1.3.268.0

Open sandercox opened this issue 2 years ago • 12 comments

  • [x] Have you signed the Contributor License Agreement?
  • [x] Have you checked that there aren't other open pull requests for the same manifest update/change?
  • [x] This PR only modifies one (1) manifest
  • [x] Have you validated your manifest locally with winget validate --manifest <path>?
  • [x] Have you tested your manifest locally with winget install --manifest <path>?
  • [x] Does your manifest conform to the 1.5 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.


Now that we have VulkanRT #133065 we can use this as a dependency for this package to make sure you can test with apps like vkcube.exe that is installed in a sandbox.

Microsoft Reviewers: Open in CodeFlow

sandercox avatar Jan 09 '24 08:01 sandercox

Service Badge  Service Badge  

wingetbot avatar Jan 09 '24 08:01 wingetbot

/AzurePipelines run

wingetbot avatar Jan 09 '24 08:01 wingetbot

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Jan 09 '24 08:01 azure-pipelines[bot]

This port was based on the work by @scribam in #123613. I did notice that the older versions of the SDK were pulled and added an agreement section to the locale to make sure users accept this license as there is no simple silent flag on the installer to ignore this. I believe it to be correct this way.

sandercox avatar Jan 09 '24 08:01 sandercox

/AzurePipelines run

wingetbot avatar Jan 09 '24 08:01 wingetbot

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Jan 09 '24 08:01 azure-pipelines[bot]

/AzurePipelines run

wingetbot avatar Jan 09 '24 16:01 wingetbot

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Jan 09 '24 16:01 azure-pipelines[bot]

Automatic Validation ended with:

2024-01-09T16:10:50.7176095Z ##[error] Manifest Error: Field usage requires verified publishers. [Agreements]

(Automated response - build 541.)

stephengillie avatar Jan 09 '24 18:01 stephengillie

[Policy] reset feedback

mdanish-kh avatar Apr 04 '24 19:04 mdanish-kh

[Policy] Reset Labels

mdanish-kh avatar Apr 04 '24 19:04 mdanish-kh

That link does not include all that is agreed upon on listed. The "AS IS" warning for instance is not part in the URL you link to so I'm not sure if this would legally be the same agreement - though the link does seem to be way more elaborate but the warning that it might miss stuff is no longer part of that... https://github.com/microsoft/winget-pkgs/pull/133387#discussion_r1553311185

Hi @sandercox,

Is there a website page, PDF document, or similar, with all of the required text? Our Agreements system is set up to expect and display an AgreementsUrl for users to visit, and might need to be revised to accept direct legal text instead of a URL.

stephengillie avatar Apr 08 '24 21:04 stephengillie

Hello @sandercox,

This pull request has been automatically marked as stale because it has been marked as requiring author feedback but has not had any recent activity. It will be closed if no further activity occurs within 3 days of this comment.

Template: msftbot/noRecentActivity