winget-create icon indicating copy to clipboard operation
winget-create copied to clipboard
verified publisher icon microsoft

Add null contitional operator to installers.installer.InstallerType

Open TheShadowEevee opened this issue 1 year ago • 4 comments

  • [x] Have you signed the Contributor License Agreement?
  • [x] Are you working against an Issue? https://github.com/microsoft/winget-create/issues/466 - Noticed separate from this issue, but found when looking for existing issues
  • Adds a Null Conditional Operator to installers.installer.InstallerType.
    • InstallerType is a required field, but is not always defined in the installer list. It may be defined for all lists earlier in the schema, so it should be potentially null here.

Additionally tested against NoMachine.NoMachine (The package I noticed this on) and Microsoft.WindowsSDK.10.0.22621 (The package from #466).

Below screenshots were generated by:

  • Running wingetcreate.exe update Microsoft.WindowsSDK.10.0.22621 -i
  • Feeding in the same Installer URL
  • Responding n then y to keep the manifest and edit it
  • Selecting INSTALLER manifest
  • Selecting Installers property
  • Observing Crash vs No Crash

Microsoft.WindowsSDK.10.0.22621 before this change: image

Microsoft.WindowsSDK.10.0.22621 after this change: image

Microsoft Reviewers: Open in CodeFlow

TheShadowEevee avatar Dec 29 '24 22:12 TheShadowEevee

/azp run

yao-msft avatar Jan 05 '25 05:01 yao-msft

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Jan 05 '25 05:01 azure-pipelines[bot]

/azp run

yao-msft avatar Mar 29 '25 03:03 yao-msft

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Mar 29 '25 03:03 azure-pipelines[bot]