winget-create icon indicating copy to clipboard operation
winget-create copied to clipboard

Allow multiple manifests to be submitted as a single PR

Open mthalman opened this issue 2 years ago • 1 comments

Description of the new feature / enhancement

Currently wingetcreate submit only allows a single manifest to be submitted to the winget-pkgs repo as a PR. This is limiting in cases where multiple manifests are associated with a single release. For example, .NET consists of multiple runtimes and an SDK, all of which are associated with a single release. But there are multiple manifests associated with this single release. Requiring separate PRs to be submitted for each manifest exposes a risk that a subset of those PRs will be auto-merged while one or more PRs may fail for some reason. This would create an inconsistent set of manifests for that product release. Depending on how customers use these packages, this kind of inconsistency could lead to their workflow breaking. To prevent this, it'd be better for a single PR to be submitted for the product release that contains changes for multiple manifests. This essentially allows for atomicity for the release's manifest updates.

Proposed technical implementation details

When calling winget submit I want to be able to pass multiple manifest paths and have a single PR generated for the whole set:

wingetcreate.exe submit --token <GitHubPersonalAccessToken> <PathToManifest1> <PathToManifest2>...

mthalman avatar Apr 07 '22 15:04 mthalman

@mthalman,

The Windows Package Manager Community Repository doesn't support multiple manifests in a single PR yet. This depends on:

  • microsoft/winget-pkgs/Issues/125

denelon avatar Apr 07 '22 18:04 denelon