winget-create icon indicating copy to clipboard operation
winget-create copied to clipboard

Submitting should check to see if there is already an open PR.

Open jedieaston opened this issue 4 years ago • 1 comments

Description of the new feature/enhancement

When a user tries to submit to the community repo, wingetcreate should use GitHub's Issue/PR search to see if there is already an open PR for that version, and if so, warn the user (with a link to the PR?).

Proposed technical implementation details (optional)

If you put in:path <path to folder or file> in GitHub's PR search, it will only show you PRs that are modifying files in a certain directory. For example, is:pr in:path manifests/m/Microsoft/Edge/94.0.992.38 gets me my PR from earlier today which adds version 94.0.992.38 of Microsoft Edge. This is also available via the API.

This could be used to stop duplicates of updates, since wingetcreate could check and see if someone already got to it first. Of course, a --force option should be present if someone really wants to try to open the PR anyway (perhaps they have some hot new metadata they want to add) but most of the time, we just get two of the same thing.

jedieaston avatar Oct 04 '21 16:10 jedieaston

I would like to suggest that this not only check for open PR's but also for closed PR's. There are several examples where packages cannot be added due to failing validation, especially for packages which require interactive installation. The latest example of this is https://github.com/microsoft/winget-pkgs/pull/37716

Additionally, if these packages do become valid at a later date, then the suggested --force option would still allow for the submission

Trenly avatar Dec 14 '21 15:12 Trenly