winget-cli Move "schema header validation" as warning only

Relevant area(s)

WinGet CLI

Relevant command(s)

No response

Brief description of your issue

Making it behind fullValidation stop our ability to run rebuilds.

@yao-msft has a good explanation on why here https://github.com/microsoft/winget-cli/pull/5236#issuecomment-2675544767

Steps to reproduce

Rebuild

Expected behavior

Not an error for fullValidation

Actual behavior

Error

Environment

winget

Oct 17 '25 02:10 msftrubengu

The community specifically wanted it as an error to prevent manifests without schema headers from being merged into the community repo. I'd rather see the manifests preventing a rebuild be fixed than make this just a warning

Oct 17 '25 12:10 Trenly

https://github.com/microsoft/winget-pkgs/pull/304521

Oct 17 '25 13:10 Trenly

Do we have a sense of how many PRs we'd need to get through to add the schema header to all the manifests?

Oct 17 '25 16:10 denelon

There are ways to make it fail on validation and not on publish and rebuild. I will push for move it out of fullValidation

Oct 17 '25 17:10 msftrubengu

Adding more context from @yao-msft and @Madhusudhan-MSFT internal investigations:

Lowering the min version in #5330 was problem. There is a gap between manifests ingested by the service and when the service started consuming that change. The intention was to require the schema starting 1.10.0 and implementing breaking changes for full validation in lower schema versions is not the right path.

Oct 17 '25 19:10 msftrubengu

Oop; That would be my fault :(

Although I had run through validation of all the manifests in the repository at the time of PR creation, it was my assumption that the service would be updated quickly; I've since run through another validation of all the manifests and found a few hundred that are affected by this

Oct 17 '25 20:10 Trenly

@msftrubengu given we've addressed the manifests in the repository, is this bug still needed, or can it be closed?

Oct 30 '25 18:10 denelon