winget-cli icon indicating copy to clipboard operation
winget-cli copied to clipboard

Winget upgrade doesn't recognize preview versions

Open jaliyaudagedara opened this issue 9 months ago • 5 comments

Brief description of your issue

I have Visual Studio 17.14.0 Preview 1.1 installed.

winget upgrade shows Visual Studio 17.14.0 as an available upgrade.

Here 7.14.0 Preview 1.1 > 17.14.0. Image

Steps to reproduce

N/A

Expected behavior

Previews versions should be considered when determining available updates.

Actual behavior

Previews versions are not considered when determining available updates.

Environment

> winget --info
Windows Package Manager v1.10.320
Copyright (c) Microsoft Corporation. All rights reserved.

Windows: Windows.Desktop v10.0.26100.3194
System Architecture: X64
Package: Microsoft.DesktopAppInstaller v1.25.320.0

Winget Directories
-------------------------------------------------------------------------------------------------------------------------------
Logs                               %LOCALAPPDATA%\Packages\Microsoft.DesktopAppInstaller_8wekyb3d8bbwe\LocalState\DiagOutputDir
User Settings                      %LOCALAPPDATA%\Packages\Microsoft.DesktopAppInstaller_8wekyb3d8bbwe\LocalState\settings.json
Portable Links Directory (User)    %LOCALAPPDATA%\Microsoft\WinGet\Links
Portable Links Directory (Machine) C:\Program Files\WinGet\Links
Portable Package Root (User)       %LOCALAPPDATA%\Microsoft\WinGet\Packages
Portable Package Root              C:\Program Files\WinGet\Packages
Portable Package Root (x86)        C:\Program Files (x86)\WinGet\Packages
Installer Downloads                %USERPROFILE%\Downloads
Configuration Modules              %LOCALAPPDATA%\Microsoft\WinGet\Configuration\Modules

Links
---------------------------------------------------------------------------
Privacy Statement   https://aka.ms/winget-privacy
License Agreement   https://aka.ms/winget-license
Third Party Notices https://aka.ms/winget-3rdPartyNotice
Homepage            https://aka.ms/winget
Windows Store Terms https://www.microsoft.com/en-us/storedocs/terms-of-sale

Admin Setting                             State
--------------------------------------------------
LocalManifestFiles                        Disabled
BypassCertificatePinningForMicrosoftStore Disabled
InstallerHashOverride                     Disabled
LocalArchiveMalwareScanOverride           Disabled
ProxyCommandLineOptions                   Disabled
DefaultProxy                              Disabled

jaliyaudagedara avatar Mar 02 '25 09:03 jaliyaudagedara

This is actually correct behavior due to how version Parsing works in WinGet.

WinGet splits the version into parts by the periods, and compares each part one at a time to determine which is greater. In this case, the comparison that determines the version order is between .0 and .0 Preview 1. Since preview versions are generally released before stable versions, the preview versions are considered a lower version (in fact, any string value after .0 would cause that version to be sorted lower)

I will note, however, that 17.14.0 does not appear on the release history page, which in this case means that whomever submitted the manifest to winget-pkgs likely made an error in the manifest, or the preview versions need stronger versioning for what the preview versions write to the registry

Trenly avatar Mar 02 '25 17:03 Trenly

This is still an issue at release of 17.14.0 Preview 3.0

mip1983 avatar Apr 17 '25 08:04 mip1983

This is still an issue at release of 17.14.0 Preview 4.0

WSESoft avatar Apr 22 '25 23:04 WSESoft

This is still an issue at release of 17.14.0 Preview 5.0

WSESoft avatar May 02 '25 10:05 WSESoft

This is still an issue at release of 17.14.0 Preview 6.0

WSESoft avatar May 10 '25 20:05 WSESoft