winget-cli icon indicating copy to clipboard operation
winget-cli copied to clipboard

Font Spec

Open ryfu-msft opened this issue 1 year ago • 4 comments

Related to #166

Adds the initial font specification document. This outlines the planned implementation for supporting fonts. This will be updated to match the actual implementation.

Microsoft Reviewers: Open in CodeFlow

ryfu-msft avatar Oct 01 '24 15:10 ryfu-msft

@check-spelling-bot Report

:red_circle: Please review

See the :open_file_folder: files view, the :scroll:action log, or :memo: job summary for details.

Unrecognized words (20)
ariali
ARIALN
ARIALNB
ARIALNI
Bahnschrift
Calibri
calibriz
DAAS
dwrite
NSim
otf
PKEY
propkey
PROPVARIANT
PRSS
pwsz
Roboto
simsun
timesbd
ttc
Previously acknowledged words that are now absent AKV Asn azcopy clsid cobertura notmatch Peet REINSTALLMODE sas SASURL similarissues similaritytolerance templating typeparam 🫥
To accept these unrecognized words as correct and remove the previously acknowledged and now absent words, you could run the following commands

... in a clone of the [email protected]:ryfu-msft/winget-cli.git repository on the fontSpec branch (:information_source: how do I use this?):

curl -s -S -L 'https://raw.githubusercontent.com/check-spelling/check-spelling/v0.0.22/apply.pl' |
perl - 'https://github.com/microsoft/winget-cli/actions/runs/11128658670/attempts/1'
Errors (1)

See the :open_file_folder: files view, the :scroll:action log, or :memo: job summary for details.

:x: Errors Count
:x: forbidden-pattern 1

See :x: Event descriptions for more information.

If the flagged items are :exploding_head: false positives

If items relate to a ...

  • binary file (or some other file you wouldn't want to check at all).

    Please add a file path to the excludes.txt file matching the containing file.

    File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

    ^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).

  • well-formed pattern.

    If you can write a pattern that would match it, try adding it to the patterns.txt file.

    Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.

    Note that patterns can't match multiline strings.

github-actions[bot] avatar Oct 01 '24 15:10 github-actions[bot]

@check-spelling-bot Report

:red_circle: Please review

See the :open_file_folder: files view, the :scroll:action log, or :memo: job summary for details.

Unrecognized words (3)

installable Retrusn Verdana

Previously acknowledged words that are now absent AKV Asn azcopy clsid cobertura notmatch Peet REINSTALLMODE sas SASURL similarissues similaritytolerance templating typeparam 🫥
To accept these unrecognized words as correct and remove the previously acknowledged and now absent words, you could run the following commands

... in a clone of the [email protected]:ryfu-msft/winget-cli.git repository on the fontSpec branch (:information_source: how do I use this?):

curl -s -S -L 'https://raw.githubusercontent.com/check-spelling/check-spelling/v0.0.22/apply.pl' |
perl - 'https://github.com/microsoft/winget-cli/actions/runs/11151822887/attempts/1'
If the flagged items are :exploding_head: false positives

If items relate to a ...

  • binary file (or some other file you wouldn't want to check at all).

    Please add a file path to the excludes.txt file matching the containing file.

    File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

    ^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).

  • well-formed pattern.

    If you can write a pattern that would match it, try adding it to the patterns.txt file.

    Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.

    Note that patterns can't match multiline strings.

github-actions[bot] avatar Oct 02 '24 21:10 github-actions[bot]

From a PowerShell point of view are we thinking something like: WinGetFont as the Object type as opposed to a WinGetPackage?

denelon avatar Oct 02 '24 21:10 denelon

From a PowerShell point of view are we thinking something like: WinGetFont as the Object type as opposed to a WinGetPackage?

I would prefer not to have to create an entire COM and PowerShell interface that is 90% the same with different names. That does mean a slant mapping of faces to versions. But version can be used to describe different flavors of things, and faces of fonts are just versions of the primary theme. So it still fits, somewhat.

JohnMcPMS avatar Oct 02 '24 21:10 JohnMcPMS

Closing this old PR. @dkbennett will author a new spec for fonts based on all the new changes and learnings.

denelon avatar Oct 08 '25 22:10 denelon