winget-cli icon indicating copy to clipboard operation
winget-cli copied to clipboard

Updates to the PowerShell modules

Open kilasuit opened this issue 1 year ago • 12 comments


Microsoft Reviewers: Open in CodeFlow

edit by @denelon - formatting for checkboxes :)

kilasuit avatar Aug 08 '24 13:08 kilasuit

@check-spelling-bot Report

:red_circle: Please review

See the :open_file_folder: files view, the :scroll:action log, or :memo: job summary for details.

Unrecognized words (19)
awgpm
awgs
dwgs
ewgp
ewgs
fdwgp
gwgp
gwgse
gwgso
gwgus
gwgv
iswgp
rpdwgpm
rswgs
rwgs
swgus
twgus
udwgp
uswgp
Previously acknowledged words that are now absent AKV azcopy clsid cobertura endregion ests Linq nameof netfx notmatch ools paramref Peet sas SASURL templating typeparam Unk 🫥
To accept these unrecognized words as correct and remove the previously acknowledged and now absent words, you could run the following commands

... in a clone of the [email protected]:kilasuit/winget-cli.git repository on the aliases branch (:information_source: how do I use this?):

curl -s -S -L 'https://raw.githubusercontent.com/check-spelling/check-spelling/v0.0.22/apply.pl' |
perl - 'https://github.com/microsoft/winget-cli/actions/runs/10303002722/attempts/1'
Errors (1)

See the :open_file_folder: files view, the :scroll:action log, or :memo: job summary for details.

:x: Errors Count
:x: ignored-expect-variant 3

See :x: Event descriptions for more information.

If the flagged items are :exploding_head: false positives

If items relate to a ...

  • binary file (or some other file you wouldn't want to check at all).

    Please add a file path to the excludes.txt file matching the containing file.

    File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

    ^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).

  • well-formed pattern.

    If you can write a pattern that would match it, try adding it to the patterns.txt file.

    Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.

    Note that patterns can't match multiline strings.

github-actions[bot] avatar Aug 08 '24 13:08 github-actions[bot]

@check-spelling-bot Report

:red_circle: Please review

See the :open_file_folder: files view, the :scroll:action log, or :memo: job summary for details.

Unrecognized words (19)
awgpm
awgs
dwgs
ewgp
ewgs
fdwgp
gwgp
gwgse
gwgso
gwgus
gwgv
iswgp
rpdwgpm
rswgs
rwgs
swgus
twgus
udwgp
uswgp
Previously acknowledged words that are now absent AKV azcopy clsid cobertura endregion ests Linq nameof netfx notmatch ools paramref Peet sas SASURL templating typeparam Unk 🫥
To accept these unrecognized words as correct and remove the previously acknowledged and now absent words, you could run the following commands

... in a clone of the [email protected]:kilasuit/winget-cli.git repository on the aliases branch (:information_source: how do I use this?):

curl -s -S -L 'https://raw.githubusercontent.com/check-spelling/check-spelling/v0.0.22/apply.pl' |
perl - 'https://github.com/microsoft/winget-cli/actions/runs/10303595126/attempts/1'
Errors (1)

See the :open_file_folder: files view, the :scroll:action log, or :memo: job summary for details.

:x: Errors Count
:x: ignored-expect-variant 3

See :x: Event descriptions for more information.

If the flagged items are :exploding_head: false positives

If items relate to a ...

  • binary file (or some other file you wouldn't want to check at all).

    Please add a file path to the excludes.txt file matching the containing file.

    File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

    ^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).

  • well-formed pattern.

    If you can write a pattern that would match it, try adding it to the patterns.txt file.

    Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.

    Note that patterns can't match multiline strings.

github-actions[bot] avatar Aug 08 '24 14:08 github-actions[bot]

@check-spelling-bot Report

:red_circle: Please review

See the :open_file_folder: files view, the :scroll:action log, or :memo: job summary for details.

Unrecognized words (29)
awgpm
awgs
cmpwgc
cnwgc
ctwgcy
dwgs
ewgp
ewgs
fdwgp
gwgc
gwgcd
gwgp
gwgse
gwgso
gwgus
gwgv
iswgp
iwgc
rpdwgpm
rswgs
rwgch
rwgs
sawgc
spwgc
swgus
twgc
twgus
udwgp
uswgp
Previously acknowledged words that are now absent AKV azcopy clsid cobertura endregion ests Linq nameof netfx notmatch ools paramref Peet sas SASURL templating typeparam Unk 🫥
To accept these unrecognized words as correct and remove the previously acknowledged and now absent words, you could run the following commands

... in a clone of the [email protected]:kilasuit/winget-cli.git repository on the aliases branch (:information_source: how do I use this?):

curl -s -S -L 'https://raw.githubusercontent.com/check-spelling/check-spelling/v0.0.22/apply.pl' |
perl - 'https://github.com/microsoft/winget-cli/actions/runs/10303627317/attempts/1'
Errors (1)

See the :open_file_folder: files view, the :scroll:action log, or :memo: job summary for details.

:x: Errors Count
:x: ignored-expect-variant 3

See :x: Event descriptions for more information.

If the flagged items are :exploding_head: false positives

If items relate to a ...

  • binary file (or some other file you wouldn't want to check at all).

    Please add a file path to the excludes.txt file matching the containing file.

    File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

    ^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).

  • well-formed pattern.

    If you can write a pattern that would match it, try adding it to the patterns.txt file.

    Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.

    Note that patterns can't match multiline strings.

github-actions[bot] avatar Aug 08 '24 14:08 github-actions[bot]

FYI I could not build this small part locally at all getting this error no matter what I do to try and build it

error MSB4019: The imported project "C:\Microsoft.Cpp.Default.props" was not found. 
Confirm that the expression in the Import declaration "\Microsoft.Cpp.Default.props" is correct, and that the file exists on disk.

I also was thinking that on push to this repo that a build would be automatically triggered, though looking at other pr's it's manually being kicked off using the /azp run mechanism (which I don't think I would be able to run)

Other than that this is ready to merge if a build completes no issue

kilasuit avatar Aug 08 '24 14:08 kilasuit

/azp run

kilasuit avatar Aug 08 '24 14:08 kilasuit

Commenter does not have sufficient privileges for PR 4716 in repo microsoft/winget-cli

azure-pipelines[bot] avatar Aug 08 '24 14:08 azure-pipelines[bot]

was worth a shot 🤷🏻‍♂️

kilasuit avatar Aug 08 '24 14:08 kilasuit

Just working on adding the additional bits needed for #4680 to get this all added in a single PR

kilasuit avatar Aug 09 '24 15:08 kilasuit

@JohnMcPMS thanks for the comments, I'll get back to these during this week (hopefully tonight) as I have some updates on another device that was in progress at the end of the week.

kilasuit avatar Aug 20 '24 12:08 kilasuit

@kilasuit thanks for jumping in here!

I think we'd want to make sure and update the appropriate "Help" files with the changes as well. Assuming this is all "non-breaking" changes, that can be a separate PR. I know we're also adding a new cmdlet for the WinGet Repair command.

denelon avatar Aug 27 '24 00:08 denelon

So this should be good for merging now & thanks for the ping @denelon - Tests and docs updated to the singular use

Only other thoughts

  • [ ] Is the file name changes for the depluralised cmdlet files ok or does this need reverting
  • [ ] Is the change to the class name as per https://github.com/microsoft/winget-cli/pull/4716/commits/696bab0e0f0fec615bb49c9bf5c9b32c11b5281e ok?
  • [ ] Do you want this rebased with cleaner commit history at all or is it fine as is?

kilasuit avatar Aug 27 '24 02:08 kilasuit

If the cmdlets have been renamed to singular, I'd say we should keep them plural unless the help files get included in the PR. Probably best to do the rename in a separate PR so the help files don't break or confuse users. Get-Help and Get-Command should stay in sync.

I'll let one of our engineers make the call on the remaining "other thoughts".

denelon avatar Aug 27 '24 17:08 denelon

Thought it best to add all in together so I have updated the helpfiles in this PR - though I can easily remove those commits if desired

kilasuit avatar Aug 28 '24 16:08 kilasuit

OK, we're cutting a build with the current cmdlets and help. As soon as that is out, we can dig back through this PR to get updates for all the changes. I really appreciate the help here!

denelon avatar Aug 28 '24 17:08 denelon

Looking good to me; we need to fix some infrastructure issues and then we can run the build/test pass.

JohnMcPMS avatar Aug 28 '24 19:08 JohnMcPMS

The following PR was just merged:

  • #4781

Those examples should be included here.

denelon avatar Sep 03 '24 14:09 denelon

/azp run

JohnMcPMS avatar Sep 03 '24 18:09 JohnMcPMS

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Sep 03 '24 18:09 azure-pipelines[bot]

The following PR was just merged:

* [Updates to PowerShell help docs #4781](https://github.com/microsoft/winget-cli/pull/4781)

Those examples should be included here.

I just rebased from the master branch & resolved the last comment so all good to go :-)

kilasuit avatar Sep 05 '24 23:09 kilasuit

/azp run

JohnMcPMS avatar Sep 05 '24 23:09 JohnMcPMS

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Sep 05 '24 23:09 azure-pipelines[bot]

/azp run

JohnMcPMS avatar Sep 06 '24 18:09 JohnMcPMS

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Sep 06 '24 18:09 azure-pipelines[bot]

Build was successful with my changes. @kilasuit, please sign off on the PR to indicate that you are done with changes and ready to merge.

JohnMcPMS avatar Sep 06 '24 22:09 JohnMcPMS

Yeah all good with me @JohnMcPMS

kilasuit avatar Sep 06 '24 22:09 kilasuit