winget-cli icon indicating copy to clipboard operation
winget-cli copied to clipboard

Agreements should not terminate entire context

Open Trenly opened this issue 1 year ago • 4 comments

Description of the new feature / enhancement

I'm trying to do an update via winget on a notebook, but it keeps giving this warning "Package contracts were not agreed. Operation cancelled." and I can't find anything about it on the internet...

CLI Output

Originally posted by @Novogumiguel in #4350

When agreements for a single package are present, --accept-package-agreements has not been specified, and WinGet is running in a non-interactive context, the entire flow is terminated. This leads to a negative user experience. Instead, only the single package which requires agreements should fail and upgrades or installs for the remaining packages should be attempted.

  • Related to #4233

Proposed technical implementation details

No response

Trenly avatar Apr 05 '24 14:04 Trenly

Hi I'm an AI powered bot that finds similar issues based off the issue title.

Please view the issues below to see if they solve your problem, and if the issue describes your problem please consider closing this one and thumbs upping the other issue to help us prioritize it. Thank you!

Open similar issues:

Closed similar issues:

Note: You can give me feedback by thumbs upping or thumbs downing this comment.

github-actions[bot] avatar Apr 05 '24 14:04 github-actions[bot]

@stephengillie - Any reason you closed #4301 as resolved? I see the SimilarIssues bot accurately identified this as being the same issue

Trenly avatar Apr 05 '24 14:04 Trenly

I hadn't closed it... the bot did it alone... but about winget it's ok, it worked...

I'm going to open another topic talking about Windows Home Single

Novogumiguel avatar Apr 05 '24 14:04 Novogumiguel

@stephengillie - Any reason you closed #4301 as resolved? I see the SimilarIssues bot accurately identified this as being the same issue

I misunderstood https://github.com/microsoft/winget-cli/issues/4233 to also be the same issue. Reviewing now, I see that's for dependencies while this is for main packages.

stephengillie avatar Apr 05 '24 15:04 stephengillie