`winget upgrade` reports package for upgrade, `--all` installs different identifier

Open Trenly opened this issue 2 years ago • 1 comments

Brief description of your issue

Related to https://github.com/microsoft/winget-pkgs/issues/94436

I have Piriform.CCleaner installed. winget upgrade detects that I have Piriform.CCleaner installed. However, running winget upgrade --all selects Piriform.CCleaner.ProTrial for installation instead of Piriform.CCleaner

Note: Piriform.CCleaner has 6.08 as the latest version and Piriform.CCleaner.ProTrial only has version 6.08.10255. I'm sure this has something to do with the ARP data, but I'm confused as to why the version for Piriform.CCleaner.ProTrial would be showing in upgrade when the package identifier is shown as Piriform.CCleaner.

Steps to reproduce

Have Piriform.CCLeaner version 6.08 installed Run winget upgrade

Expected behavior

Piriform.CCleaner is not listed for upgrade

Actual behavior

WinGet-2023-02-15-21-08-43.640.log

PS D:\Git\winget-pkgs> winget upgrade --all
Name                              Id                                     Version        Available
-----------------------------------------------------------------------------------------------------
CCleaner                          Piriform.CCleaner                      6.08           6.08.10255
Git                               Git.Git                                2.39.1         2.39.2
Microsoft Visual Studio Installer Microsoft.VisualStudio.2019.BuildTools 3.4.2246.31370 16.11.23
Microsoft .NET SDK 6.0.406 (x86)  Microsoft.DotNet.SDK.5                 > 5.0.408      6.0.406
Microsoft Edge                    Microsoft.Edge                         110.0.1587.41  110.0.1587.46
CORSAIR iCUE 4 Software           Corsair.iCUE.4                         4.32.129       4.33.138
Microsoft .NET SDK 6.0.406 (x64)  Microsoft.DotNet.SDK.5                 > 5.0.408      6.0.406
7 upgrades available.
2 package(s) have pins that prevent upgrade. Use the 'winget pin' command to view and edit pins. Using the --include-pinned argument may show more results.

(1/6) Found CCleaner Professional Trial [Piriform.CCleaner.ProTrial] Version 6.08.10255
This application is licensed to you by its owner.
Microsoft is not responsible for, nor does it grant any licenses to, third-party packages.
Downloading https://download.ccleaner.com/cctrialsetup.exe
  ██████████████████████████████  50.6 MB / 50.6 MB

Environment

PS D:\Git\winget-pkgs> winget --info
Windows Package Manager (Preview) v1.5.441-preview
Copyright (c) Microsoft Corporation. All rights reserved.

Windows: Windows.Desktop v10.0.19044.2604
System Architecture: X64
Package: Microsoft.DesktopAppInstaller v1.20.441.0

Logs: %LOCALAPPDATA%\Packages\Microsoft.DesktopAppInstaller_8wekyb3d8bbwe\LocalState\DiagOutputDir

User Settings: %LOCALAPPDATA%\Packages\Microsoft.DesktopAppInstaller_8wekyb3d8bbwe\LocalState\settings.json

Links
---------------------------------------------------------------------------
Privacy Statement   https://aka.ms/winget-privacy
License Agreement   https://aka.ms/winget-license
Third Party Notices https://aka.ms/winget-3rdPartyNotice
Homepage            https://aka.ms/winget
Windows Store Terms https://www.microsoft.com/en-us/storedocs/terms-of-sale

Admin Setting                             State
--------------------------------------------------
LocalManifestFiles                        Enabled
BypassCertificatePinningForMicrosoftStore Disabled
InstallerHashOverride                     Disabled
LocalArchiveMalwareScanOverride           Disabled

Feb 16 '23 03:02 Trenly

Adding onto this - it seems the Misdetection also does not respect pins. I tried adding a pin to block the upgrade and it still attempted to install Piriform.CCleaner.ProTrial

Feb 16 '23 03:02 Trenly