microsoft
Show Enabled Admin Settings in --info
- [x] Have you signed the Contributor License Agreement?
- [x] Are you working against an Issue?
- #2898
This is only a partial implementation, as the user settings are much more complicated. The table is only output if there are AdminSettings enabled, and only shows the admin settings that are enabled
@denelon, does this align with what you visioned for showing admin settings? Basically this is showing a list of enabled admin settings, those not enabled were not shown.
![azure-pipelines[bot] avatar](https://avatars.githubusercontent.com/in/9426?v=4 "Published by a pub.dev verified publisher"){kind=small}
I was actually thinking about whether it makes sense to show all of them and their state. Group policy objects are either "Enabled", "Disabled", or "Not Configured". I don't know that it makes sense to display them all or not. It could be inconsistent to not display the ones that aren't configured, but their states is a tuple so maybe it's OK.
Links
---------------------------------------------------------------------------
Privacy Statement https://aka.ms/winget-privacy
License Agreement https://aka.ms/winget-license
Third Party Notices https://aka.ms/winget-3rdPartyNotice
Homepage https://aka.ms/winget
Windows Store Terms https://www.microsoft.com/en-us/storedocs/terms-of-sale
Group Policy State
----------------------------------------------------------
Enable Windows App Installer Local Manifest Files Enabled
Enable Windows App Installer Hash Override Disabled
Admin Settings State
----------------------------------------------------------
BypassCertificatePinningForMicrosoftStore Disabled
InstallerHashOverride Disabled
LocalArchiveMalwareScanOverride Disabled
LocalManifestFiles Enabled
I was actually thinking about whether it makes sense to show all of them and their state. Group policy objects are either "Enabled", "Disabled", or "Not Configured". I don't know that it makes sense to display them all or not. It could be inconsistent to not display the ones that aren't configured, but their states is a tuple so maybe it's OK.
Links --------------------------------------------------------------------------- Privacy Statement https://aka.ms/winget-privacy License Agreement https://aka.ms/winget-license Third Party Notices https://aka.ms/winget-3rdPartyNotice Homepage https://aka.ms/winget Windows Store Terms https://www.microsoft.com/en-us/storedocs/terms-of-sale Group Policy State ---------------------------------------------------------- Enable Windows App Installer Local Manifest Files Enabled Enable Windows App Installer Hash Override Disabled Admin Settings State ---------------------------------------------------------- BypassCertificatePinningForMicrosoftStore Disabled InstallerHashOverride Disabled LocalArchiveMalwareScanOverride Disabled LocalManifestFiles Enabled
It's a small change to show all of them. Can have it done in ~5 minutes.
My thought was that group policies are only shown if they are present and configured. There are more than 2 group policies available, but since only 2 are configured, they are the only ones shown in the list.
For Admin settings they are always present and configured (default to false); It could become a very cluttered output if they were all shown. I could see, perhaps, a middle ground where they are hidden by default, but if any one of them is enabled then show all of them with state.
@denelon - Just need a decision on what you think is best UX
- Show all admin settings with their status all the time
- Show all admin settings with their status only when any admin setting is enabled
- Show only the admin settings which are currently enabled