winget-cli icon indicating copy to clipboard operation
winget-cli copied to clipboard

Relative File Path is Validated Literally

Open Trenly opened this issue 2 years ago • 1 comments

Brief description of your issue

Relative file paths should be validated by where they resolve to, rather than by their literal strings

Steps to reproduce

Have a zip installer with nested portable types. Use the same relative path for both, but prefix one with ./

Example: RelativeFilePath: ./example.exe | RelativeFilePath: example.exe

Expected behavior

Manifest Validation should fail with the duplicate relative path warning

Actual behavior

Validation succeeds

microsoft/winget-pkgs@37960ed (#94699)

Environment

Winget 1.4

Trenly avatar Jan 27 '23 12:01 Trenly

Please also consider the possibility of multiple PortableCommandAliases for a single RelativeFilePath (https://github.com/microsoft/winget-cli/issues/2884)

sitiom avatar Feb 02 '23 08:02 sitiom

@denelon - Tag portable please?

Trenly avatar Mar 10 '23 19:03 Trenly