winget-cli icon indicating copy to clipboard operation
winget-cli copied to clipboard

Use INSTALLDIR as install location switch for WiX installers

Open SpecterShell opened this issue 3 years ago • 0 comments


MSI installers built by WiX Toolset use different switches such as INSTALLDIR instead of TARGETDIR as install location parameter. While adding new packages and reworking old packages, I noticed that most WiX installers are using INSTALLDIR. I felt that it is necessary to replace the current install location switch with INSTALLDIR since some new building toolchains like Tauri Builder are using WiX as the default installer builder, where developers are less likely to modify the WiX template and don't know what switches should be used for WinGet manifest.

However, the custom location switch may vary among WiX installers according to https://github.com/microsoft/winget-cli/issues/1857#issuecomment-1127011986. In case of potential conner cases, I will draft this PR and look into the remaining packages in winget-pkgs repo to see the proportion of switches they are using.


Some of the conner cases:

  • INSTALLLOCATION
    • LiErHeXun.Quicker
Microsoft Reviewers: Open in CodeFlow

SpecterShell avatar Nov 04 '22 16:11 SpecterShell