winget-cli icon indicating copy to clipboard operation
winget-cli copied to clipboard

[Zip] Nested Installer Files Validation

Open Trenly opened this issue 3 years ago • 2 comments

  • Non-Portable Installer Type doesn't warn when PortableCommandAlias is included for a NestedInstallerFile

Note: The below items are likely not implemented yet, as Portable support hasn't been implemented for Zip files yet. I'm placing them here as a consideration to ensure they are validated against

  • Portable Installer Type doesn't throw an error when two entries have the same RelativeFilePath
    • This might be acceptable as long as they have different command aliases?
  • Portable Installer Type doesn't throw an error when two entries have the same PortableCommandAlias

Trenly avatar Sep 17 '22 02:09 Trenly

@ryfu-msft please take a look at this.

denelon avatar Sep 19 '22 14:09 denelon

Thanks for catching this, additional validation will be added in #2500

ryfu-msft avatar Sep 20 '22 21:09 ryfu-msft

  • This might be acceptable as long as they have different command aliases?

Seems like this isn't implemented: https://github.com/microsoft/winget-pkgs/pull/94699#issuecomment-1404896681

sitiom avatar Jan 26 '23 11:01 sitiom

This version isn't in the validation pipelines yet. We're waiting for the 1.4 client rollout to the majority of users. We want to avoid as much confusion as possible with the "winget" source having .zip-based packages they can't install with earlier versions of winget.

denelon avatar Jan 26 '23 16:01 denelon

What I mean is that winget validate fails locally and that an exception should be made for the same RelativeFilePath but different PortableCommandAlias.

sitiom avatar Jan 26 '23 22:01 sitiom

@sitiom can you create a new issue with an example?

denelon avatar Jan 26 '23 23:01 denelon

https://github.com/microsoft/winget-cli/issues/2884

sitiom avatar Jan 26 '23 23:01 sitiom