winget-cli
winget-cli copied to clipboard
[Zip] Nested Installer Files Validation
- Non-Portable Installer Type doesn't warn when
PortableCommandAliasis included for a NestedInstallerFile
Note: The below items are likely not implemented yet, as Portable support hasn't been implemented for Zip files yet. I'm placing them here as a consideration to ensure they are validated against
- Portable Installer Type doesn't throw an error when two entries have the same
RelativeFilePath- This might be acceptable as long as they have different command aliases?
- Portable Installer Type doesn't throw an error when two entries have the same
PortableCommandAlias
@ryfu-msft please take a look at this.
Thanks for catching this, additional validation will be added in #2500
- This might be acceptable as long as they have different command aliases?
Seems like this isn't implemented: https://github.com/microsoft/winget-pkgs/pull/94699#issuecomment-1404896681
This version isn't in the validation pipelines yet. We're waiting for the 1.4 client rollout to the majority of users. We want to avoid as much confusion as possible with the "winget" source having .zip-based packages they can't install with earlier versions of winget.
What I mean is that winget validate fails locally and that an exception should be made for the same RelativeFilePath but different PortableCommandAlias.
@sitiom can you create a new issue with an example?
https://github.com/microsoft/winget-cli/issues/2884